Fix JsonPatchDocument review feedback

Copilot · captainsafia · Copilot · commit 20c16b20d3e0 · 2025-05-22T19:59:39.000Z
Co-authored-by: captainsafia &lt;1857993+captainsafia@users.noreply.github.com&gt;
diff --git a/src/Features/JsonPatch.SystemTextJson/src/JsonPatchDocument.cs b/src/Features/JsonPatch.SystemTextJson/src/JsonPatchDocument.cs
@@ -227,13 +227,11 @@ IList<Operation> IJsonPatchDocument.GetOperations()
     /// </summary>
     /// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>
     /// <param name="builder">The endpoint builder for the endpoint being constructed.</param>
-#pragma warning disable RS0016 // Add public types and members to the declared API
     public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)
-#pragma warning restore RS0016 // Add public types and members to the declared API
     {
         ArgumentNullException.ThrowIfNull(parameter);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));
+        builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], parameter.ParameterType));
     }
 }
diff --git a/src/Features/JsonPatch.SystemTextJson/src/JsonPatchDocumentOfT.cs b/src/Features/JsonPatch.SystemTextJson/src/JsonPatchDocumentOfT.cs
@@ -664,14 +664,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()
     /// </summary>
     /// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>
     /// <param name="builder">The endpoint builder for the endpoint being constructed.</param>
-#pragma warning disable RS0016 // Add public types and members to the declared API
     public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)
-#pragma warning restore RS0016 // Add public types and members to the declared API
     {
         ArgumentNullException.ThrowIfNull(parameter);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));
+        builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], typeof(TModel)));
     }
 
     // Internal for testing
diff --git a/src/Features/JsonPatch.SystemTextJson/src/PublicAPI.Unshipped.txt b/src/Features/JsonPatch.SystemTextJson/src/PublicAPI.Unshipped.txt
@@ -6,6 +6,7 @@ Microsoft.AspNetCore.JsonPatch.SystemTextJson.Exceptions.JsonPatchException.Json
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.IJsonPatchDocument
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument.JsonPatchDocument() -> void
+Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument.PopulateMetadata(System.Reflection.ParameterInfo parameter, Microsoft.AspNetCore.Builder.EndpointBuilder builder) -> void
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>.JsonPatchDocument() -> void
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchError
 Microsoft.AspNetCore.JsonPatch.SystemTextJson.Operations.Operation
@@ -52,6 +53,7 @@ Microsoft.AspNetCore.JsonPatch.SystemTextJson.Operations.OperationType.Test = 5
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument.SerializerOptions.set -> void
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument.Test(string path, object value) -> Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>
+~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>.PopulateMetadata(System.Reflection.ParameterInfo parameter, Microsoft.AspNetCore.Builder.EndpointBuilder builder) -> void
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>.Add<TProp>(System.Linq.Expressions.Expression<System.Func<TModel, System.Collections.Generic.IList<TProp>>> path, TProp value) -> Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>.Add<TProp>(System.Linq.Expressions.Expression<System.Func<TModel, System.Collections.Generic.IList<TProp>>> path, TProp value, int position) -> Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>
 ~Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>.Add<TProp>(System.Linq.Expressions.Expression<System.Func<TModel, TProp>> path, TProp value) -> Microsoft.AspNetCore.JsonPatch.SystemTextJson.JsonPatchDocument<TModel>
diff --git a/src/Features/JsonPatch/src/JsonPatchDocument.cs b/src/Features/JsonPatch/src/JsonPatchDocument.cs
@@ -235,14 +235,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()
     /// </summary>
     /// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>
     /// <param name="builder">The endpoint builder for the endpoint being constructed.</param>
-#pragma warning disable RS0016 // Add public types and members to the declared API
     public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)
-#pragma warning restore RS0016 // Add public types and members to the declared API
     {
         ArgumentNullException.ThrowIfNull(parameter);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));
+        builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], parameter.ParameterType));
     }
 #endif
 }
diff --git a/src/Features/JsonPatch/src/JsonPatchDocumentOfT.cs b/src/Features/JsonPatch/src/JsonPatchDocumentOfT.cs
@@ -672,14 +672,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()
     /// </summary>
     /// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>
     /// <param name="builder">The endpoint builder for the endpoint being constructed.</param>
-#pragma warning disable RS0016 // Add public types and members to the declared API
     public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)
-#pragma warning restore RS0016 // Add public types and members to the declared API
     {
         ArgumentNullException.ThrowIfNull(parameter);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));
+        builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], typeof(TModel)));
     }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -227,13 +227,11 @@ IList<Operation> IJsonPatchDocument.GetOperations()`
`227`	`227`	`/// </summary>`
`228`	`228`	`/// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>`
`229`	`229`	`/// <param name="builder">The endpoint builder for the endpoint being constructed.</param>`
`230`		`-#pragma warning disable RS0016 // Add public types and members to the declared API`
`231`	`230`	`public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)`
`232`		`-#pragma warning restore RS0016 // Add public types and members to the declared API`
`233`	`231`	`{`
`234`	`232`	`ArgumentNullException.ThrowIfNull(parameter);`
`235`	`233`	`ArgumentNullException.ThrowIfNull(builder);`
`236`	`234`
`237`		`- builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));`
	`235`	`+ builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], parameter.ParameterType));`
`238`	`236`	`}`
`239`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -664,14 +664,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()`
`664`	`664`	`/// </summary>`
`665`	`665`	`/// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>`
`666`	`666`	`/// <param name="builder">The endpoint builder for the endpoint being constructed.</param>`
`667`		`-#pragma warning disable RS0016 // Add public types and members to the declared API`
`668`	`667`	`public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)`
`669`		`-#pragma warning restore RS0016 // Add public types and members to the declared API`
`670`	`668`	`{`
`671`	`669`	`ArgumentNullException.ThrowIfNull(parameter);`
`672`	`670`	`ArgumentNullException.ThrowIfNull(builder);`
`673`	`671`
`674`		`- builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));`
	`672`	`+ builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], typeof(TModel)));`
`675`	`673`	`}`
`676`	`674`
`677`	`675`	`// Internal for testing`
Original file line number	Diff line number	Diff line change
`@@ -235,14 +235,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()`
`235`	`235`	`/// </summary>`
`236`	`236`	`/// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>`
`237`	`237`	`/// <param name="builder">The endpoint builder for the endpoint being constructed.</param>`
`238`		`-#pragma warning disable RS0016 // Add public types and members to the declared API`
`239`	`238`	`public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)`
`240`		`-#pragma warning restore RS0016 // Add public types and members to the declared API`
`241`	`239`	`{`
`242`	`240`	`ArgumentNullException.ThrowIfNull(parameter);`
`243`	`241`	`ArgumentNullException.ThrowIfNull(builder);`
`244`	`242`
`245`		`- builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));`
	`243`	`+ builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], parameter.ParameterType));`
`246`	`244`	`}`
`247`	`245`	`#endif`
`248`	`246`	`}`
Original file line number	Diff line number	Diff line change
`@@ -672,14 +672,12 @@ IList<Operation> IJsonPatchDocument.GetOperations()`
`672`	`672`	`/// </summary>`
`673`	`673`	`/// <param name="parameter">The <see cref="ParameterInfo"/> for the endpoint parameter.</param>`
`674`	`674`	`/// <param name="builder">The endpoint builder for the endpoint being constructed.</param>`
`675`		`-#pragma warning disable RS0016 // Add public types and members to the declared API`
`676`	`675`	`public static void PopulateMetadata(ParameterInfo parameter, EndpointBuilder builder)`
`677`		`-#pragma warning restore RS0016 // Add public types and members to the declared API`
`678`	`676`	`{`
`679`	`677`	`ArgumentNullException.ThrowIfNull(parameter);`
`680`	`678`	`ArgumentNullException.ThrowIfNull(builder);`
`681`	`679`
`682`		`- builder.Metadata.Add(new AcceptsMetadata(new[] { "application/json-patch+json" }, parameter.ParameterType));`
	`680`	`+ builder.Metadata.Add(new AcceptsMetadata(["application/json-patch+json"], typeof(TModel)));`
`683`	`681`	`}`
`684`	`682`	`#endif`
`685`	`683`