Skip to content

Commit 52d7707

Browse files
authored
set TreatWarningsAsErrors to true (#1897)
* set TreatWarningsAsErrors to true to ensure that no new warnings are being added * solve the only warning we have
1 parent 387ca0e commit 52d7707

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

build/common.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<UseSharedCompilation>false</UseSharedCompilation>
1919
<SuppressNETCoreSdkPreviewMessage>True</SuppressNETCoreSdkPreviewMessage>
2020
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingStyle.ruleset</CodeAnalysisRuleSet>
21+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2122
</PropertyGroup>
2223

2324
<ItemGroup>

src/BenchmarkDotNet.Diagnostics.Windows/EtwProfilerConfig.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public class EtwProfilerConfig
1818
public float CpuSampleIntervalInMilliseconds { get; }
1919

2020
public KernelTraceEventParser.Keywords KernelKeywords { get; }
21+
2122
public KernelTraceEventParser.Keywords KernelStackKeywords { get; }
2223

2324
public IReadOnlyDictionary<HardwareCounter, Func<ProfileSourceInfo, int>> IntervalSelectors { get; }
@@ -31,6 +32,7 @@ public class EtwProfilerConfig
3132
/// <param name="cpuSampleIntervalInMilliseconds">The rate at which CPU samples are collected. By default this is 1 (once a millisecond per CPU). There is a lower bound on this (typically 0.125 ms)</param>
3233
/// <param name="intervalSelectors">interval per hardware counter, if not provided then default values will be used.</param>
3334
/// <param name="kernelKeywords">kernel session keywords, ImageLoad (for native stack frames) and Profile (for CPU Stacks) are the defaults</param>
35+
/// <param name="kernelStackKeywords">This is passed to TraceEventSession.EnableKernelProvider to enable particular sets of events. See https://docs.microsoft.com/windows/win32/api/evntrace/ns-evntrace-event_trace_properties#members for more information on them.</param>
3436
/// <param name="providers">providers that should be enabled, if not provided then default values will be used</param>
3537
/// <param name="createHeapSession">value indicating whether to create heap session. False by default, used internally by NativeMemoryProfiler.</param>
3638
public EtwProfilerConfig(

0 commit comments

Comments
 (0)