Skip to content

Commit 0d9e53d

Browse files
committed
Add test for filtering multiple connections
1 parent af735b5 commit 0d9e53d

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

tests/DependencyInjection/DoctrineMigrationsExtensionTest.php

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,10 @@ public function testCustomConnection(): void
279279
$di = $container->get('doctrine.migrations.dependency_factory');
280280
self::assertInstanceOf(DependencyFactory::class, $di);
281281
self::assertSame($doctrine->getConnection('custom'), $di->getConnection());
282+
// Check if the multiple connections also added the required tags to the filter
283+
$filterDefinition = $container->findDefinition('doctrine_migrations.schema_filter_listener');
284+
$tags = $filterDefinition->getTag('doctrine.dbal.schema_filter');
285+
self::assertCount(2, $tags);
282286
}
283287

284288
public function testPrefersEntityManagerOverConnection(): void
@@ -466,9 +470,6 @@ private function getContainer(array $config, ?array $dbalConfig = null, ?array $
466470
$bundle = new DoctrineMigrationsBundle();
467471
$bundle->build($container);
468472

469-
$extension = new DoctrineMigrationsExtension();
470-
$extension->load(['doctrine_migrations' => $config], $container);
471-
472473
$extension = new DoctrineExtension();
473474

474475
$doctrineBundleConfigs = $dbalConfig === null ? ['dbal' => ['url' => 'sqlite:///:memory:']] : ['dbal' => $dbalConfig];
@@ -478,8 +479,15 @@ private function getContainer(array $config, ?array $dbalConfig = null, ?array $
478479

479480
$extension->load(['doctrine' => $doctrineBundleConfigs], $container);
480481

482+
$extension = new DoctrineMigrationsExtension();
483+
$extension->load(['doctrine_migrations' => $config], $container);
484+
481485
$container->getDefinition('doctrine.migrations.dependency_factory')->setPublic(true);
482486
$container->getDefinition('doctrine.migrations.configuration')->setPublic(true);
487+
if ($container->hasDefinition('doctrine_migrations.schema_filter_listener')) {
488+
$container->getDefinition('doctrine_migrations.schema_filter_listener')->setPublic(true);
489+
}
490+
483491
$container->addCompilerPass(new CacheCompatibilityPass());
484492

485493
return $container;

0 commit comments

Comments
 (0)