Skip to content

Commit 5c086cb

Browse files
committed
Fix remaining test failures
1 parent b9088db commit 5c086cb

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

Tests/DependencyInjection/ConfigurationTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
use PHPUnit\Framework\TestCase;
77

88
use function class_exists;
9+
use function extension_loaded;
10+
11+
use const PHP_VERSION_ID;
912

1013
class ConfigurationTest extends TestCase
1114
{
@@ -23,8 +26,13 @@ class ConfigurationTest extends TestCase
2326
/** @runInSeparateProcess */
2427
public function testGetConfigTreeBuilderDoNotUseDoctrineCommon(): void
2528
{
29+
if (extension_loaded('pcov') && PHP_VERSION_ID >= 80100) {
30+
$this->markTestSkipped('Segfaults, see https://github.com/krakjoe/pcov/issues/84');
31+
}
32+
2633
$configuration = new Configuration(true);
2734
$configuration->getConfigTreeBuilder();
35+
2836
$this->assertFalse(class_exists('Doctrine\Common\Proxy\AbstractProxyFactory', false));
2937
}
3038
}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"symfony/cache": "^4.3.3|^5.0|^6.0",
3535
"symfony/config": "^4.4.3|^5.0|^6.0",
3636
"symfony/console": "^3.4.30|^4.3.3|^5.0|^6.0",
37-
"symfony/dependency-injection": "^4.3.3|^5.0|^6.0",
37+
"symfony/dependency-injection": "^4.4.18|^5.0|^6.0",
3838
"symfony/deprecation-contracts": "^2.1|^3",
3939
"symfony/doctrine-bridge": "^4.4.22|^5.2.7|^6.0",
4040
"symfony/framework-bundle": "^3.4.30|^4.3.3|^5.0|^6.0",

0 commit comments

Comments
 (0)