Skip to content

Commit 0b47e6e

Browse files
authored
Merge pull request #1475 from greg0ire/fix-build
Fix build
2 parents 100687e + b2fa2aa commit 0b47e6e

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

.github/workflows/coding-standards.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,5 @@ jobs:
1313
coding-standards:
1414
name: "Coding Standards"
1515
uses: "doctrine/.github/.github/workflows/coding-standards.yml@1.4.1"
16+
with:
17+
composer-options: "--prefer-dist --prefer-stable"

Mapping/ClassMetadataFactory.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Doctrine\ORM\Id\AbstractIdGenerator;
66
use Doctrine\ORM\Mapping\ClassMetadata;
77
use Doctrine\ORM\Mapping\ClassMetadataFactory as BaseClassMetadataFactory;
8-
use Doctrine\ORM\Mapping\ClassMetadataInfo;
98

109
use function assert;
1110

@@ -18,10 +17,6 @@ protected function doLoadMetadata($class, $parent, $rootEntityFound, array $nonS
1817
{
1918
parent::doLoadMetadata($class, $parent, $rootEntityFound, $nonSuperclassParents);
2019

21-
if (! $class instanceof ClassMetadataInfo) {
22-
return;
23-
}
24-
2520
$customGeneratorDefinition = $class->customGeneratorDefinition;
2621

2722
if (! isset($customGeneratorDefinition['instance'])) {

Tests/DependencyInjection/DoctrineExtensionTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -764,12 +764,11 @@ public function testAnnotationsBundleMappingDetection(): void
764764
]);
765765
}
766766

767+
/**
768+
* @requires PHP 8
769+
*/
767770
public function testAttributesBundleMappingDetection(): void
768771
{
769-
if (PHP_VERSION_ID < 70400) {
770-
self::markTestSkipped('This test requires PHP 7.4.');
771-
}
772-
773772
$container = $this->getContainer(['AttributesBundle']);
774773
$extension = new DoctrineExtension();
775774

Tests/Repository/ContainerRepositoryFactoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public function findOneBy(array $criteria)
210210

211211
public function getClassName(): string
212212
{
213-
return '';
213+
return stdClass::class;
214214
}
215215
}
216216

0 commit comments

Comments
 (0)