Merge branch 'develop' into feat/vue-options

Author: jhildenbiddle

packages/docsify-server-renderer/package-lock.json

@@ -15,9 +15,9 @@
     "test": "echo 'hello'"
   },
   "dependencies": {
-    "debug": "^4.1.1",
+    "debug": "^4.3.0",
     "docsify": "^4.11.6",
-    "dompurify": "^2.0.17",
+    "dompurify": "^2.1.1",
     "node-fetch": "^2.6.0",
     "resolve-pathname": "^3.0.0"
   }

packages/docsify-server-renderer/package.json

@@ -5,7 +5,7 @@ import { tree as treeTpl } from './tpl';
 import { genTree } from './gen-tree';
 import { slugify } from './slugify';
 import { emojify } from './emojify';
-import { getAndRemoveConfig } from './utils';
+import { getAndRemoveConfig, removeAtag } from './utils';
 import { imageCompiler } from './compiler/image';
 import { highlightCodeCompiler } from './compiler/code';
 import { paragraphCompiler } from './compiler/paragraph';
@@ -206,29 +206,29 @@ export class Compiler {
      */
     origin.heading = renderer.heading = function(text, level) {
       let { str, config } = getAndRemoveConfig(text);
-      const nextToc = { level, title: str };
+      const nextToc = { level, title: removeAtag(str) };
 
       if (/<!-- {docsify-ignore} -->/g.test(str)) {
         str = str.replace('<!-- {docsify-ignore} -->', '');
-        nextToc.title = str;
+        nextToc.title = removeAtag(str);
         nextToc.ignoreSubHeading = true;
       }
 
       if (/{docsify-ignore}/g.test(str)) {
         str = str.replace('{docsify-ignore}', '');
-        nextToc.title = str;
+        nextToc.title = removeAtag(str);
         nextToc.ignoreSubHeading = true;
       }
 
       if (/<!-- {docsify-ignore-all} -->/g.test(str)) {
         str = str.replace('<!-- {docsify-ignore-all} -->', '');
-        nextToc.title = str;
+        nextToc.title = removeAtag(str);
         nextToc.ignoreAllSubs = true;
       }
 
       if (/{docsify-ignore-all}/g.test(str)) {
         str = str.replace('{docsify-ignore-all}', '');
-        nextToc.title = str;
+        nextToc.title = removeAtag(str);
         nextToc.ignoreAllSubs = true;
       }
 

src/core/render/compiler.js

@@ -1,32 +1,32 @@
-import { getAndRemoveConfig } from '../utils';
+import { getAndRemoveConfig, removeAtag } from '../utils';
 import { slugify } from './slugify';
 
 export const headingCompiler = ({ renderer, router, _self }) =>
   (renderer.code = (text, level) => {
     let { str, config } = getAndRemoveConfig(text);
-    const nextToc = { level, title: str };
+    const nextToc = { level, title: removeAtag(str) };
 
     if (/<!-- {docsify-ignore} -->/g.test(str)) {
       str = str.replace('<!-- {docsify-ignore} -->', '');
-      nextToc.title = str;
+      nextToc.title = removeAtag(str);
       nextToc.ignoreSubHeading = true;
     }
 
     if (/{docsify-ignore}/g.test(str)) {
       str = str.replace('{docsify-ignore}', '');
-      nextToc.title = str;
+      nextToc.title = removeAtag(str);
       nextToc.ignoreSubHeading = true;
     }
 
     if (/<!-- {docsify-ignore-all} -->/g.test(str)) {
       str = str.replace('<!-- {docsify-ignore-all} -->', '');
-      nextToc.title = str;
+      nextToc.title = removeAtag(str);
       nextToc.ignoreAllSubs = true;
     }
 
     if (/{docsify-ignore-all}/g.test(str)) {
       str = str.replace('{docsify-ignore-all}', '');
-      nextToc.title = str;
+      nextToc.title = removeAtag(str);
       nextToc.ignoreAllSubs = true;
     }
 

src/core/render/compiler/headline.js

@@ -38,3 +38,13 @@ export function getAndRemoveConfig(str = '') {
 
   return { str, config };
 }
+
+/**
+ * Remove the <a> tag from sidebar when the header with link, details see issue 1069
+ * @param {string}   str   The string to deal with.
+ *
+ * @return {string}   str   The string after delete the <a> element.
+ */
+export function removeAtag(str = '') {
+  return str.replace(/(<\/?a.*?>)/gi, '');
+}

src/core/render/utils.js

@@ -226,6 +226,9 @@ export function init(config, vm) {
         namespaceSuffix = matches[0];
       }
     }
+    paths.unshift(namespaceSuffix + '/');
+  } else {
+    paths.unshift('/');
   }
 
   const expireKey = resolveExpireKey(config.namespace) + namespaceSuffix;

src/plugins/search/search.js

@@ -0,0 +1,38 @@
+const docsifyInit = require('../helpers/docsify-init');
+
+// Suite
+// -----------------------------------------------------------------------------
+describe('Search Plugin Tests', function() {
+  // Tests
+  // ---------------------------------------------------------------------------
+  test('search readme', async () => {
+    const docsifyInitConfig = {
+      markdown: {
+        homepage: `
+          # Hello World
+
+          This is the homepage.
+        `,
+        sidebar: `
+          - [Home page](/)
+          - [Test Page](test)
+        `,
+      },
+      routes: {
+        '/test.md': `
+          # Test Page
+
+          This is a custom route.
+        `,
+      },
+      scriptURLs: ['/lib/plugins/search.min.js'],
+    };
+
+    await docsifyInit(docsifyInitConfig);
+    await page.fill('input[type=search]', 'hello');
+    await expect(page).toEqualText('.results-panel h2', 'Hello World');
+    await page.click('.clear-button');
+    await page.fill('input[type=search]', 'test');
+    await expect(page).toEqualText('.results-panel h2', 'Test Page');
+  });
+});

test/e2e/search.test.js

@@ -0,0 +1,15 @@
+const { removeAtag } = require(`${SRC_PATH}/core/render/utils`);
+
+// Suite
+// -----------------------------------------------------------------------------
+describe('core/render/utils', () => {
+  // removeAtag()
+  // ---------------------------------------------------------------------------
+  describe('removeAtag()', () => {
+    test('removeAtag from a link', () => {
+      const result = removeAtag('<a href="www.example.com">content</a>');
+
+      expect(result).toEqual('content');
+    });
+  });
+});