Skip to content

Commit 29ee158

Browse files
committed
move initRender into the renderMixin class
1 parent 097edd5 commit 29ee158

File tree

2 files changed

+58
-58
lines changed

2 files changed

+58
-58
lines changed

src/core/init/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import config from '../config';
2-
import { initRender } from '../render';
32
import { initEvent } from '../event';
43
import { initFetch } from '../fetch';
54

@@ -12,7 +11,7 @@ export function initMixin(Base = class {}) {
1211
this.initPlugin(); // Install plugins
1312
this.callHook('init');
1413
this.initRouter(); // Add router
15-
initRender(this); // Render base DOM
14+
this.initRender(); // Render base DOM
1615
initEvent(this); // Bind events
1716
initFetch(this); // Fetch data
1817
this.callHook('mounted');

src/core/render/index.js

Lines changed: 57 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -232,74 +232,75 @@ export function renderMixin(Base = class {}) {
232232
// Render name link
233233
renderNameLink(this);
234234
}
235-
};
236-
}
237235

238-
export function initRender(vm) {
239-
const config = vm.config;
236+
initRender() {
237+
const config = this.config;
240238

241-
// Init markdown compiler
242-
vm.compiler = new Compiler(config, vm.router);
243-
if (inBrowser) {
244-
window.__current_docsify_compiler__ = vm.compiler;
245-
}
239+
// Init markdown compiler
240+
this.compiler = new Compiler(config, this.router);
241+
if (inBrowser) {
242+
// TODO @trusktr, get rid of globals!
243+
window.__current_docsify_compiler__ = this.compiler;
244+
}
246245

247-
const id = config.el || '#app';
248-
const navEl = dom.find('nav') || dom.create('nav');
246+
const id = config.el || '#app';
247+
const navEl = dom.find('nav') || dom.create('nav');
249248

250-
const el = dom.find(id);
251-
let html = '';
252-
let navAppendToTarget = dom.body;
249+
const el = dom.find(id);
250+
let html = '';
251+
let navAppendToTarget = dom.body;
253252

254-
if (el) {
255-
if (config.repo) {
256-
html += tpl.corner(config.repo, config.cornerExternalLinkTarge);
257-
}
253+
if (el) {
254+
if (config.repo) {
255+
html += tpl.corner(config.repo, config.cornerExternalLinkTarge);
256+
}
258257

259-
if (config.coverpage) {
260-
html += tpl.cover();
261-
}
258+
if (config.coverpage) {
259+
html += tpl.cover();
260+
}
262261

263-
if (config.logo) {
264-
const isBase64 = /^data:image/.test(config.logo);
265-
const isExternal = /(?:http[s]?:)?\/\//.test(config.logo);
266-
const isRelative = /^\./.test(config.logo);
262+
if (config.logo) {
263+
const isBase64 = /^data:image/.test(config.logo);
264+
const isExternal = /(?:http[s]?:)?\/\//.test(config.logo);
265+
const isRelative = /^\./.test(config.logo);
267266

268-
if (!isBase64 && !isExternal && !isRelative) {
269-
config.logo = getPath(vm.router.getBasePath(), config.logo);
270-
}
271-
}
267+
if (!isBase64 && !isExternal && !isRelative) {
268+
config.logo = getPath(this.router.getBasePath(), config.logo);
269+
}
270+
}
272271

273-
html += tpl.main(config);
274-
// Render main app
275-
vm._renderTo(el, html, true);
276-
} else {
277-
vm.rendered = true;
278-
}
272+
html += tpl.main(config);
273+
// Render main app
274+
this._renderTo(el, html, true);
275+
} else {
276+
this.rendered = true;
277+
}
279278

280-
if (config.mergeNavbar && isMobile) {
281-
navAppendToTarget = dom.find('.sidebar');
282-
} else {
283-
navEl.classList.add('app-nav');
279+
if (config.mergeNavbar && isMobile) {
280+
navAppendToTarget = dom.find('.sidebar');
281+
} else {
282+
navEl.classList.add('app-nav');
284283

285-
if (!config.repo) {
286-
navEl.classList.add('no-badge');
287-
}
288-
}
284+
if (!config.repo) {
285+
navEl.classList.add('no-badge');
286+
}
287+
}
289288

290-
// Add nav
291-
if (config.loadNavbar) {
292-
dom.before(navAppendToTarget, navEl);
293-
}
289+
// Add nav
290+
if (config.loadNavbar) {
291+
dom.before(navAppendToTarget, navEl);
292+
}
294293

295-
if (config.themeColor) {
296-
dom.$.head.appendChild(
297-
dom.create('div', tpl.theme(config.themeColor)).firstElementChild
298-
);
299-
// Polyfll
300-
cssVars(config.themeColor);
301-
}
294+
if (config.themeColor) {
295+
dom.$.head.appendChild(
296+
dom.create('div', tpl.theme(config.themeColor)).firstElementChild
297+
);
298+
// Polyfll
299+
cssVars(config.themeColor);
300+
}
302301

303-
vm._render_updateRender();
304-
dom.toggleClass(dom.body, 'ready');
302+
this._render_updateRender();
303+
dom.toggleClass(dom.body, 'ready');
304+
}
305+
};
305306
}

0 commit comments

Comments
 (0)