Skip to content

Commit a00d28f

Browse files
committed
Disable Codecov (for now)
It's been failing to upload for a while, and I don't think the failures are *completely* their fault (GitHub's got to share some of the blame, I think), but the end result is that we don't really have any good options for continuing to use the service (bad/unacceptable options include install an app with way too many privileges on the org/repo or add a "secret" with a personal access token ... and make that available to Pull Requests too 🙃).
1 parent 5734481 commit a00d28f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,13 @@ jobs:
4242
run: |
4343
docker build --pull --file Dockerfile.test --tag test .
4444
docker run --rm test cat coverage.out > coverage.out
45-
- name: Codecov
46-
uses: codecov/codecov-action@v3
47-
with:
48-
files: coverage.out
49-
fail_ci_if_error: true
50-
verbose: true
45+
# TODO find a suitable codecov solution that doesn't require privileged access to the org/repo
46+
#- name: Codecov
47+
# uses: codecov/codecov-action@v3
48+
# with:
49+
# files: coverage.out
50+
# fail_ci_if_error: true
51+
# verbose: true
5152
dockerfile:
5253
name: Test Dockerfile
5354
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)