Fixed migrations

Author: Aiky30

CHANGELOG.rst

@@ -5,6 +5,8 @@ Changelog
 Unreleased
 ==================
 * fix: Error when rendering a Draft Snippet plugin on a Published page
+* fix: Cleanup unnecessary migration files
+* fix: Publish snippets by default as they were already in that state pre-versioning!
 * feat: djangocms-versioning support added, including model restructure and configuration
 * feat: django-cms v4.0.x support added
 

djangocms_snippet/migrations/0010_cms4_grouper_version_data_migration.py

@@ -29,24 +29,28 @@ def cms4_grouper_version_migration(apps, schema_editor):
     snippet_contenttype = ContentType.objects.get(app_label='djangocms_snippet', model='snippet')
     snippet_queryset = Snippet.objects.all()
 
+    # Get a migration user to create a version.
+    if djangocms_versioning_config_enabled and djangocms_versioning_installed:
+        Version = apps.get_model('djangocms_versioning', 'Version')
+
+        migration_user = User.objects.get(id=DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID)
+
     for snippet in snippet_queryset:
         grouper = SnippetGrouper.objects.create()
         snippet.snippet_grouper = grouper
         snippet.save()
 
-        # Get a migration user.
-        migration_user = User.objects.get(id=DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID)
-
         # Create initial Snippet Versions if versioning is enabled and installed.
         if djangocms_versioning_config_enabled and djangocms_versioning_installed:
-            Version = apps.get_model('djangocms_versioning', 'Version')
-            Version.objects.create(
+            snippet_version = Version.objects.create(
                 created_by=migration_user,
                 state=DRAFT,
                 number=1,
                 object_id=snippet.pk,
                 content_type=snippet_contenttype,
             )
+            # Publish the snippet because all snippets were assumed published before
+            snippet_version.publish(migration_user)
 
 
 class Migration(migrations.Migration):

djangocms_snippet/migrations/0012_auto_20210915_0721.py

@@ -17,12 +17,26 @@ class Migration(migrations.Migration):
         ),
         migrations.AlterField(
             model_name='snippet',
-            name='snippet_grouper',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='djangocms_snippet.SnippetGrouper'),
+            name='name',
+            field=models.CharField(max_length=255, verbose_name='Name'),
+        ),
+        migrations.AlterField(
+            model_name='snippet',
+            name='slug',
+            field=models.SlugField(default='', max_length=255, verbose_name='Slug'),
+        ),
+        migrations.AlterModelOptions(
+            name='snippet',
+            options={'verbose_name': 'Snippet', 'verbose_name_plural': 'Snippets'},
         ),
         migrations.AlterField(
             model_name='snippetptr',
             name='snippet_grouper',
             field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='djangocms_snippet.SnippetGrouper'),
         ),
+        migrations.AlterField(
+            model_name='snippet',
+            name='snippet_grouper',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='djangocms_snippet.SnippetGrouper'),
+        ),
     ]