Skip to content

Commit da34c01

Browse files
ci: auto fixes from pre-commit hooks
for more information, see https://pre-commit.ci
1 parent cdf3bfa commit da34c01

19 files changed

+126
-216
lines changed

aldryn_config.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,14 @@ def to_settings(self, data, settings):
2424
env = partial(djsenv, settings=settings)
2525

2626
# Get a migration user if the env setting has been added
27-
migration_user_id = env(
28-
'DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID',
29-
default=False
30-
)
27+
migration_user_id = env("DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID", default=False)
3128
if migration_user_id:
32-
settings['DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID'] = int(migration_user_id)
29+
settings["DJANGOCMS_SNIPPET_VERSIONING_MIGRATION_USER_ID"] = int(migration_user_id)
3330

34-
if data['editor_theme']:
35-
settings['DJANGOCMS_SNIPPET_THEME'] = data['editor_theme']
36-
if data['editor_mode']:
37-
settings['DJANGOCMS_SNIPPET_MODE'] = data['editor_mode']
38-
if data['enable_search']:
39-
settings['DJANGOCMS_SNIPPET_SEARCH'] = data['enable_search']
31+
if data["editor_theme"]:
32+
settings["DJANGOCMS_SNIPPET_THEME"] = data["editor_theme"]
33+
if data["editor_mode"]:
34+
settings["DJANGOCMS_SNIPPET_MODE"] = data["editor_mode"]
35+
if data["enable_search"]:
36+
settings["DJANGOCMS_SNIPPET_SEARCH"] = data["enable_search"]
4037
return settings

src/djangocms_snippet/admin.py

Lines changed: 11 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818

1919
# Use the version mixin if djangocms-versioning is installed and enabled
2020
snippet_admin_classes = [admin.ModelAdmin]
21-
djangocms_versioning_enabled = getattr(
22-
settings, "DJANGOCMS_SNIPPET_VERSIONING_ENABLED", True
23-
)
21+
djangocms_versioning_enabled = getattr(settings, "DJANGOCMS_SNIPPET_VERSIONING_ENABLED", True)
2422

2523
try:
2624
try:
@@ -56,9 +54,7 @@ class Media:
5654
"data-theme": getattr(settings, "DJANGOCMS_SNIPPET_MODE", "github"),
5755
}
5856
form = SnippetForm
59-
formfield_overrides: ClassVar[dict] = {
60-
models.TextField: {"widget": Textarea(attrs=text_area_attrs)}
61-
}
57+
formfield_overrides: ClassVar[dict] = {models.TextField: {"widget": Textarea(attrs=text_area_attrs)}}
6258
# This was move here from model, otherwise first() and last() return the same when handling grouper queries
6359
ordering = ("name",)
6460

@@ -101,41 +97,29 @@ def get_list_display_links(self, request, list_display):
10197
self.list_display_links = (None,)
10298
return self.list_display_links
10399

104-
def preview_view(
105-
self, request, snippet_id=None, form_url="", extra_context=None
106-
):
100+
def preview_view(self, request, snippet_id=None, form_url="", extra_context=None):
107101
"""
108102
Custom preview endpoint to display a change form in read only mode
109103
Solution based on django changeform view implementation
110104
https://github.com/django/django/blob/4b8e9492d9003ca357a4402f831112dd72efd2f8/django/contrib/admin/options.py#L1553
111105
"""
112-
to_field = request.POST.get(
113-
TO_FIELD_VAR, request.GET.get(TO_FIELD_VAR)
114-
)
106+
to_field = request.POST.get(TO_FIELD_VAR, request.GET.get(TO_FIELD_VAR))
115107

116108
if to_field and not self.to_field_allowed(request, to_field):
117-
raise DisallowedModelAdminToField(
118-
f"The field {to_field} cannot be referenced."
119-
)
109+
raise DisallowedModelAdminToField(f"The field {to_field} cannot be referenced.")
120110

121111
model = self.model
122112
opts = model._meta
123113

124114
obj = self.get_object(request, unquote(str(snippet_id)), to_field)
125115

126116
if obj is None:
127-
return self._get_obj_does_not_exist_redirect(
128-
request, opts, str(snippet_id)
129-
)
117+
return self._get_obj_does_not_exist_redirect(request, opts, str(snippet_id))
130118

131119
fieldsets = self.get_fieldsets(request, obj)
132-
model_form = self.get_form(
133-
request, obj, change=False, fields=flatten_fieldsets(fieldsets)
134-
)
120+
model_form = self.get_form(request, obj, change=False, fields=flatten_fieldsets(fieldsets))
135121
form = model_form(instance=obj)
136-
formsets, inline_instances = self._create_formsets(
137-
request, obj, change=True
138-
)
122+
formsets, inline_instances = self._create_formsets(request, obj, change=True)
139123

140124
readonly_fields = flatten_fieldsets(fieldsets)
141125

@@ -149,9 +133,7 @@ def preview_view(
149133
)
150134
media = self.media + admin_form.media
151135

152-
inline_formsets = self.get_inline_formsets(
153-
request, formsets, inline_instances, obj
154-
)
136+
inline_formsets = self.get_inline_formsets(request, formsets, inline_instances, obj)
155137
for inline_formset in inline_formsets:
156138
media = media + inline_formset.media
157139

@@ -163,8 +145,7 @@ def preview_view(
163145
"adminform": admin_form,
164146
"object_id": snippet_id,
165147
"original": obj,
166-
"is_popup": IS_POPUP_VAR in request.POST
167-
or IS_POPUP_VAR in request.GET,
148+
"is_popup": IS_POPUP_VAR in request.POST or IS_POPUP_VAR in request.GET,
168149
"to_field": to_field,
169150
"media": media,
170151
"inline_admin_formsets": inline_formsets,
@@ -188,7 +169,7 @@ def get_urls(self):
188169
path(
189170
"<int:snippet_id>/preview/",
190171
self.admin_site.admin_view(self.preview_view),
191-
name=f"{self.model._meta.app_label}_{self.model._meta.model_name}_preview"
172+
name=f"{self.model._meta.app_label}_{self.model._meta.model_name}_preview",
192173
),
193174
*super().get_urls(),
194175
]

src/djangocms_snippet/cms_config.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@
1313

1414

1515
class SnippetCMSAppConfig(CMSAppConfig):
16-
djangocms_versioning_enabled = getattr(
17-
settings, "DJANGOCMS_SNIPPET_VERSIONING_ENABLED", True
18-
)
19-
djangocms_moderation_enabled = getattr(
20-
settings, "DJANGOCMS_SNIPPET_MODERATION_ENABLED", True
21-
)
16+
djangocms_versioning_enabled = getattr(settings, "DJANGOCMS_SNIPPET_VERSIONING_ENABLED", True)
17+
djangocms_moderation_enabled = getattr(settings, "DJANGOCMS_SNIPPET_MODERATION_ENABLED", True)
2218

2319
cms_enabled = True
2420
# cms toolbar enabled to allow for versioning compare view

src/djangocms_snippet/cms_plugins.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ def render(self, context, instance, placeholder):
4040
t = template.Template(snippet.html)
4141
content = t.render(context)
4242
except template.TemplateDoesNotExist:
43-
content = _("Template %(template)s does not exist.") % {
44-
"template": snippet.template
45-
}
43+
content = _("Template %(template)s does not exist.") % {"template": snippet.template}
4644
except Exception as e:
4745
content = escape(str(e))
4846

src/djangocms_snippet/forms.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,13 @@ def clean(self):
3737
snippet_queryset = Snippet.objects.all()
3838

3939
if djangocms_versioning_enabled and is_versioning_installed and snippet_grouper:
40-
snippet_queryset = snippet_queryset.exclude(snippet_grouper=snippet_grouper)
40+
snippet_queryset = snippet_queryset.exclude(snippet_grouper=snippet_grouper)
4141

4242
for snippet in snippet_queryset:
4343
if snippet.name == name:
44-
self.add_error(
45-
"name", _("A Snippet with this name already exists")
46-
)
44+
self.add_error("name", _("A Snippet with this name already exists"))
4745
elif snippet.slug == slug:
48-
self.add_error(
49-
"slug", _("A Snippet with this slug already exists")
50-
)
46+
self.add_error("slug", _("A Snippet with this slug already exists"))
5147

5248
return data
5349

@@ -63,7 +59,6 @@ def save(self, **kwargs):
6359

6460

6561
class SnippetPluginForm(forms.ModelForm):
66-
6762
class Meta:
6863
model = SnippetPtr
6964
fields = ("cmsplugin_ptr", "snippet_grouper")

src/djangocms_snippet/models.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,7 @@ class Snippet(models.Model):
8989
default="",
9090
max_length=255,
9191
)
92-
site = models.ForeignKey(
93-
Site, on_delete=models.CASCADE, null=True, blank=True
94-
)
92+
site = models.ForeignKey(Site, on_delete=models.CASCADE, null=True, blank=True)
9593

9694
objects = models.Manager()
9795
admin_manager = AdminQuerySet.as_manager()
@@ -131,9 +129,7 @@ class SnippetPtr(CMSPlugin):
131129
search_fields = ["snippet__html"] if SEARCH_ENABLED else []
132130

133131
def get_short_description(self):
134-
snippet_label = SnippetGrouper.objects.filter(
135-
pk=self.snippet_grouper.pk
136-
).first()
132+
snippet_label = SnippetGrouper.objects.filter(pk=self.snippet_grouper.pk).first()
137133
return snippet_label
138134

139135
class Meta:

src/djangocms_snippet/rendering.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33

44
def render_snippet(request, snippet):
5-
template = 'djangocms_snippet/admin/preview.html'
6-
context = {'snippet': snippet}
5+
template = "djangocms_snippet/admin/preview.html"
6+
context = {"snippet": snippet}
77
return TemplateResponse(request, template, context)

src/djangocms_snippet/templatetags/snippet_tags.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ def render(self, context):
7272
elif isinstance(snippet_instance, int): # pragma: no cover
7373
snippet_instance = Snippet.objects.get(pk=snippet_instance)
7474

75-
return mark_safe(
76-
self.get_content_render(context, snippet_instance)
77-
)
75+
return mark_safe(self.get_content_render(context, snippet_instance))
7876

7977
# Rely on the fact that manager something went wrong
8078
# render the fallback template
@@ -100,9 +98,7 @@ def get_content_render(self, context, instance):
10098
t = template.Template(instance.html)
10199
content = t.render(context)
102100
except template.TemplateDoesNotExist:
103-
content = _("Template %(template)s does not exist.") % {
104-
"template": instance.template
105-
}
101+
content = _("Template %(template)s does not exist.") % {"template": instance.template}
106102
except Exception as e: # pragma: no cover
107103
content = escape(str(e))
108104
if self.parse_until:
@@ -127,9 +123,7 @@ def do_snippet_fragment(parser, token):
127123
"""
128124
args = token.split_contents()
129125
if len(args) < EXPECTED_LENGTH:
130-
raise template.TemplateSyntaxError(
131-
'You need to specify at least a "snippet" ID, slug or instance'
132-
)
126+
raise template.TemplateSyntaxError('You need to specify at least a "snippet" ID, slug or instance')
133127
if "or" in args:
134128
# Catch contents between tags and pass to renderer
135129
args.append(parser.parse(("endsnippet_fragment",)))

src/djangocms_snippet/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,4 @@ def show_draft_content(request=None):
2020
if not request:
2121
return False
2222
request_toolbar = get_toolbar_from_request(request)
23-
return request_toolbar.edit_mode_active or getattr(
24-
request_toolbar, "preview_mode_active", True
25-
)
23+
return request_toolbar.edit_mode_active or getattr(request_toolbar, "preview_mode_active", True)

tests/settings.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
11
#!/usr/bin/env python
22

33
try:
4-
import djangocms_versioning #NOQA: F401
4+
import djangocms_versioning # NOQA: F401
55

6-
add_apps = ['djangocms_versioning']
6+
add_apps = ["djangocms_versioning"]
77
except ImportError:
88
add_apps = []
99

1010
HELPER_SETTINGS = {
11-
'SECRET_KEY': "djangocmssnippetstestsuitekey",
12-
'INSTALLED_APPS': [
13-
'tests.utils',
14-
'djangocms_snippet',
11+
"SECRET_KEY": "djangocmssnippetstestsuitekey",
12+
"INSTALLED_APPS": [
13+
"tests.utils",
14+
"djangocms_snippet",
1515
*add_apps,
1616
],
17-
'CMS_LANGUAGES': {
18-
1: [{
19-
'code': 'en',
20-
'name': 'English',
21-
}]
17+
"CMS_LANGUAGES": {
18+
1: [
19+
{
20+
"code": "en",
21+
"name": "English",
22+
}
23+
]
2224
},
23-
'LANGUAGE_CODE': 'en',
24-
'ALLOWED_HOSTS': ['localhost'],
25-
'DJANGOCMS_SNIPPET_VERSIONING_ENABLED': True,
26-
'DJANGOCMS_SNIPPET_MODERATION_ENABLED': True,
27-
'CMS_TEMPLATES': (
28-
("page.html", "Normal page"),
29-
),
25+
"LANGUAGE_CODE": "en",
26+
"ALLOWED_HOSTS": ["localhost"],
27+
"DJANGOCMS_SNIPPET_VERSIONING_ENABLED": True,
28+
"DJANGOCMS_SNIPPET_MODERATION_ENABLED": True,
29+
"CMS_TEMPLATES": (("page.html", "Normal page"),),
3030
"DEFAULT_AUTO_FIELD": "django.db.models.AutoField",
3131
"CMS_CONFIRM_VERSION4": True,
3232
}

0 commit comments

Comments
 (0)