Skip to content

Commit acc29ad

Browse files
committed
review changes + fixed after applying suggestions
1 parent c9fc307 commit acc29ad

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

lib/src/compatDiktat2Dot0Dot0/java/com/diffplug/spotless/glue/diktat/compat/DiktatCompat2Dot0Dot0Adapter.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@
1515
*/
1616
package com.diffplug.spotless.glue.diktat.compat;
1717

18-
import java.io.*;
18+
import java.io.File;
19+
import java.io.FileInputStream;
20+
import java.io.IOException;
21+
import java.io.InputStream;
1922
import java.util.ArrayList;
2023
import java.util.Collections;
2124
import java.util.List;

lib/src/compatDiktatApi/java/com/diffplug/spotless/glue/diktat/compat/DiktatReporting.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
interface DiktatReporting {
2323
static <T> void reportIfRequired(
24-
List<T> errors,
25-
ToIntFunction<T> lineGetter,
26-
ToIntFunction<T> columnGetter,
27-
Function<T, String> detailGetter) {
24+
List<T> errors,
25+
ToIntFunction<T> lineGetter,
26+
ToIntFunction<T> columnGetter,
27+
Function<T, String> detailGetter) {
2828
if (!errors.isEmpty()) {
2929
StringBuilder error = new StringBuilder();
3030
error.append("There are ").append(errors.size()).append(" unfixed errors:");

lib/src/main/java/com/diffplug/spotless/kotlin/DiktatStep.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,13 @@ static final class State implements Serializable {
7878
final JarState jar;
7979

8080
State(String versionDiktat, Provisioner provisioner, boolean isScript, @Nullable FileSignature config) throws IOException {
81-
HashSet<String> pkgSet = new HashSet<>();
8281
final String diktatCoordinate;
8382
if (BadSemver.version(versionDiktat) >= BadSemver.version(PACKAGE_RELOCATED_VERSION)) {
8483
diktatCoordinate = MAVEN_COORDINATE + versionDiktat;
8584
} else {
8685
diktatCoordinate = MAVEN_COORDINATE_PRE_2_0_0 + versionDiktat;
8786
}
8887
this.jar = JarState.from(diktatCoordinate, provisioner);
89-
90-
this.jar = JarState.from(pkgSet, provisioner);
9188
this.versionDiktat = versionDiktat;
9289
this.isScript = isScript;
9390
this.config = config;

0 commit comments

Comments
 (0)