Merge pull request #2 from arushi09-hub/readme-fixes

README: Small content fixes in readme, resource limits & requests added for deployment

Author: pghildiyal

README.md

@@ -1,8 +1,5 @@
 # getting-started-nodejs
 
-[![wercker status](https://app.wercker.com/status/7b1a402dd00d57fc9abddf9eb5161675/s "wercker status")](https://app.wercker.com/project/bykey/7b1a402dd00d57fc9abddf9eb5161675)
- ample application in Javascript on NodeJS for Wercker
-
 This application uses the `node` container obtained from the [Docker Hub](https://hub.docker.com/_/node/)
 
 ## Setup
@@ -23,21 +20,6 @@ Now point your browser at `http://localhost:8080` to see:
 {"cities":["Amsterdam","Berlin","New York","San Francisco","Tokyo"]}
 ```
 
-The second, and more useful, way is to use the `wercker dev` command to launch the binary within a Docker container, using the base image defined in the `box/id` property at the top of the `wercker.yml`, like so:
-```
-wercker dev --expose-ports
-```
-The `dev` target inside `wercker.yml` uses the `internal/watch` step to dynamically reload the runtime container when sourcefile changes are detected, which allows you to quickly test changes without having to kill/rebuild/relaunch the container. For instance, add another city to the array on `app.js:3' like so:
-
-```
-var cities = {"cities":["Amsterdam","Berlin","New York","San Francisco","Tokyo","London"]}
-```
-
-and then refresh your browser pointing to `http://localhost:8080` to see:
-```
-{"cities":["Amsterdam","Berlin","New York","San Francisco","Tokyo","London"]}}
-```
-
 ## Getting started with deploying application through Devtron
 
 Lets see how to deploy a custom nodejs app through Devtron. 
@@ -61,6 +43,18 @@ ContainerPort :
 ```
 `8080` is the port number on which my nodejs application is running. 
 
+Set the resource limits & requests as given below -
+
+```
+resources:
+    limits:
+        cpu: "0.5"
+        memory: 50Mi
+    requests:
+        cpu: "0.1"
+        memory: 10Mi
+```
+
 Now, select the serviceType, keep it as `LoadBalancer`. 
 
 ```
@@ -92,9 +86,4 @@ Use this URL on your browser and you can get the output as.
 Find out a detailed documentation about the configurations from here - https://docs.devtron.ai/devtron/user-guide/creating-application
 
 ---
-Sign up for Wercker: http://www.wercker.com
-
-Learn more at: http://devcenter.wercker.com
-17
-18