Be specific for the namespace of the id attribute (php#14060)

nielsdos · web-flow · commit b0da6ed6eeec · 2024-04-28T11:40:54.000+02:00
diff --git a/ext/dom/html5_parser.c b/ext/dom/html5_parser.c
@@ -226,7 +226,7 @@ static lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert(
                 last_added_attr = lxml_attr;
 
                 /* xmlIsID does some other stuff too that is irrelevant here. */
-                if (local_name_length == 2 && local_name[0] == 'i' && local_name[1] == 'd') {
+                if (local_name_length == 2 && local_name[0] == 'i' && local_name[1] == 'd' && attr->node.ns == LXB_NS_HTML) {
                     xmlAddID(NULL, lxml_doc, value, lxml_attr);
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ static lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert(`
`226`	`226`	`last_added_attr = lxml_attr;`
`227`	`227`
`228`	`228`	`/* xmlIsID does some other stuff too that is irrelevant here. */`
`229`		`- if (local_name_length == 2 && local_name[0] == 'i' && local_name[1] == 'd') {`
	`229`	`+ if (local_name_length == 2 && local_name[0] == 'i' && local_name[1] == 'd' && attr->node.ns == LXB_NS_HTML) {`
`230`	`230`	`xmlAddID(NULL, lxml_doc, value, lxml_attr);`
`231`	`231`	`}`
`232`	`232`