Fixed PHPUnit complaints of risky tests with no assertions.

Author: willvincent

tests/PostgresEngineTest.php

@@ -32,25 +32,25 @@ public function update_adds_object_to_index()
         [$engine, $db] = $this->getEngine();
 
         $db->shouldReceive('query')
-            ->andReturn($query = Mockery::mock('stdClass'));
+            ->andReturn($query = Mockery::mock('stdClass'))->once();
         $query->shouldReceive('selectRaw')
             ->with(
                 'to_tsvector(COALESCE(?, get_current_ts_config()), ?) || setweight(to_tsvector(COALESCE(?, get_current_ts_config()), ?), ?) AS tsvector',
                 [null, 'Foo', null, '', 'B']
             )
-            ->andReturnSelf();
+            ->andReturnSelf()->once();
         $query->shouldReceive('value')
             ->with('tsvector')
-            ->andReturn('foo');
+            ->andReturn('foo')->once();
 
         $db->shouldReceive('table')
             ->andReturn($table = Mockery::mock('stdClass'));
         $table->shouldReceive('where')
             ->with('id', '=', 1)
-            ->andReturnSelf();
+            ->andReturnSelf()->once();
 
         $table->shouldReceive('update')
-            ->with(['searchable' => 'foo']);
+            ->with(['searchable' => 'foo'])->once();
 
         $engine->update(Collection::make([new TestModel]));
     }
@@ -62,7 +62,7 @@ public function update_do_nothing_if_index_maintenance_turned_off_globally()
     {
         [$engine] = $this->getEngine(['maintain_index' => false]);
 
-        $engine->update(Collection::make([new TestModel]));
+        $this->assertNull($engine->update(Collection::make([new TestModel])));
     }
 
     /**
@@ -73,12 +73,15 @@ public function delete_removes_object_from_index()
         [$engine, $db] = $this->getEngine();
 
         $db->shouldReceive('table')
-            ->andReturn($table = Mockery::mock('stdClass'));
+            ->andReturn($table = Mockery::mock('stdClass'))
+            ->once();
         $table->shouldReceive('whereIn')
             ->with('id', [1])
-            ->andReturnSelf();
+            ->andReturnSelf()
+            ->once();
         $table->shouldReceive('update')
-            ->with(['searchable' => null]);
+            ->with(['searchable' => null])
+            ->once();
 
         $engine->delete(Collection::make([new TestModel]));
     }
@@ -142,7 +145,8 @@ public function search()
             ->shouldReceive('getBindings')->andReturn([null, 'foo', 1, 'qux']);
 
         $db->shouldReceive('select')
-            ->with(null, $table->getBindings());
+            ->with(null, $table->getBindings())
+            ->once();
 
         $builder = new Builder(new TestModel, 'foo');
         $builder->where('bar', 1)
@@ -166,7 +170,8 @@ public function search_with_order_by()
             ->shouldReceive('getBindings')->andReturn([null, 'foo']);
 
         $db->shouldReceive('select')
-            ->with(null, $table->getBindings());
+            ->with(null, $table->getBindings())
+            ->once();
 
         $builder = new Builder(new TestModel, 'foo');
         $builder->orderBy('bar', 'desc')
@@ -191,7 +196,7 @@ public function search_with_global_config()
             ->shouldReceive('where')->with('bar', 1)
             ->shouldReceive('getBindings')->andReturn(['simple', 'foo', 1]);
 
-        $db->shouldReceive('select')->with(null, $table->getBindings());
+        $db->shouldReceive('select')->with(null, $table->getBindings())->once();
 
         $builder = new Builder(new TestModel, 'foo');
         $builder->where('bar', 1)->take(5);
@@ -215,7 +220,7 @@ public function search_with_model_config()
             ->shouldReceive('where')->with('bar', 1)
             ->shouldReceive('getBindings')->andReturn(['english', 'foo', 1]);
 
-        $db->shouldReceive('select')->with(null, $table->getBindings());
+        $db->shouldReceive('select')->with(null, $table->getBindings())->once();
 
         $model = new TestModel;
         $model->searchableOptions['config'] = 'english';
@@ -241,7 +246,7 @@ public function search_with_soft_deletes()
             ->shouldReceive('whereNull')->with('deleted_at')
             ->shouldReceive('getBindings')->andReturn([null, 'foo', 1]);
 
-        $db->shouldReceive('select')->with(null, $table->getBindings());
+        $db->shouldReceive('select')->with(null, $table->getBindings())->once();
 
         $builder = new Builder(new SoftDeletableTestModel, 'foo');
         $builder->where('bar', 1)->take(5);