Skip to content

Commit 4f66ec6

Browse files
rename closeTabIDs parameter to closedTabIDs
1 parent a9f0179 commit 4f66ec6

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/useDynamicTabs/useDynamicTabs.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ function useDynamicTabs(getDeps, options = {}) {
2828
}, []);
2929
useLayoutEffect(() => {
3030
const oldState = api.getCopyPerviousData(),
31-
[openedTabIDs, closeTabIDs] = api.helper.getArraysDiff(state.openTabIDs, oldState.openTabIDs),
31+
[openedTabIDs, closedTabIDs] = api.helper.getArraysDiff(state.openTabIDs, oldState.openTabIDs),
3232
isSwitched = oldState.selectedTabID !== state.selectedTabID;
33-
api.onChange({newState: state, oldState, closeTabIDs, openedTabIDs, isSwitched});
33+
api.onChange({newState: state, oldState, closedTabIDs, openedTabIDs, isSwitched});
3434
}, [state]);
3535
useLayoutEffect(() => {
3636
api.trigger('_onFlushEffects', api.userProxy, {currentData: api.getCopyData(), instance: api.userProxy});

src/utils/api/api.factory.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ const _apiProps = {
5151
return this;
5252
},
5353
_subscribeSelectedTabsHistory: function () {
54-
this.on('onChange', ({currentData, perviousData, closeTabIDs}) => {
55-
for (let i = 0, l = closeTabIDs.length; i < l; i++) {
56-
this.activedTabsHistory.remove(closeTabIDs[i]);
54+
this.on('onChange', ({currentData, perviousData, closedTabIDs}) => {
55+
for (let i = 0, l = closedTabIDs.length; i < l; i++) {
56+
this.activedTabsHistory.remove(closedTabIDs[i]);
5757
}
5858
const isSwitched = perviousData.selectedTabID !== currentData.selectedTabID;
5959
if (isSwitched && this.isOpen(perviousData.selectedTabID) && !this.isSelected(perviousData.selectedTabID))
@@ -167,16 +167,16 @@ const _apiProps = {
167167
},
168168
};
169169
Helper.setNoneEnumProps(_apiProps, {
170-
onChange: function ({newState, oldState, closeTabIDs, openedTabIDs, isSwitched}) {
171-
if (isSwitched || openedTabIDs.length || closeTabIDs.length) {
170+
onChange: function ({newState, oldState, closedTabIDs, openedTabIDs, isSwitched}) {
171+
if (isSwitched || openedTabIDs.length || closedTabIDs.length) {
172172
this.trigger('onChange', this.userProxy, {
173173
currentData: {...newState},
174174
perviousData: {...oldState},
175-
closeTabIDs,
175+
closedTabIDs,
176176
openedTabIDs,
177177
});
178178
openedTabIDs.length && this.trigger('onOpen', this.userProxy, openedTabIDs);
179-
closeTabIDs.length && this.trigger('onClose', this.userProxy, closeTabIDs);
179+
closedTabIDs.length && this.trigger('onClose', this.userProxy, closedTabIDs);
180180
isSwitched &&
181181
this.trigger('onSelect', this.userProxy, {
182182
currentSelectedTabId: newState.selectedTabID,

src/utils/api/api.factory.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ describe('context of callback options should be userProxy object : ', () => {
323323
};
324324
const obj = new apiConstructor(getDeps, {options});
325325
expect(options.onChange.mock.calls.length === 0).toBe(true);
326-
obj.trigger('onChange', obj.userProxy, {currentData: {}, perviousData: {}, closeTabIDs: [], openTabIDs: []});
326+
obj.trigger('onChange', obj.userProxy, {currentData: {}, perviousData: {}, closedTabIDs: [], openTabIDs: []});
327327
expect(options.onChange.mock.calls.length === 1).toBe(true);
328328
});
329329
});
@@ -475,8 +475,8 @@ describe('Api.prototype._subscribeSelectedTabsHistory : ', () => {
475475
obj.activedTabsHistory.remove = jest.fn(() => {});
476476
const currentData = {selectedTabID: '2', openTabIDs: ['2']};
477477
const perviousData = {selectedTabID: '2', openTabIDs: ['2']};
478-
const closeTabIDs = ['1', '3'];
479-
obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closeTabIDs, openTabIDs: []});
478+
const closedTabIDs = ['1', '3'];
479+
obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closedTabIDs, openTabIDs: []});
480480
expect(obj.activedTabsHistory.remove.mock.calls.length).toBe(2);
481481
expect(obj.activedTabsHistory.remove.mock.calls[0][0]).toBe('1');
482482
expect(obj.activedTabsHistory.remove.mock.calls[1][0]).toBe('3');
@@ -494,7 +494,7 @@ describe('Api.prototype._subscribeSelectedTabsHistory : ', () => {
494494
});
495495
const currentData = {selectedTabID: '2', openTabIDs: ['1', '2']};
496496
const perviousData = {selectedTabID: '1', openTabIDs: ['1', '2']};
497-
obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closeTabIDs: [], openTabIDs: []});
497+
obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closedTabIDs: [], openTabIDs: []});
498498
expect(obj.activedTabsHistory.add.mock.calls.length).toBe(1);
499499
expect(obj.activedTabsHistory.add.mock.calls[0][0]).toBe('1');
500500
});

0 commit comments

Comments
 (0)