Skip to content

Commit 03e37b2

Browse files
ES6 import&export : fix circular dependencies
by updating default options
1 parent b1e72b8 commit 03e37b2

File tree

6 files changed

+9
-21
lines changed

6 files changed

+9
-21
lines changed

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11

2-
import useDynamicTabs from './useDynamicTabs/index.js';
2+
import useDynamicTabs from './useDynamicTabs/useDynamicTabs.js';
33
export default useDynamicTabs;

src/useDynamicTabs/index.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/useDynamicTabs/index.tast.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/useDynamicTabs/index.test.js

Whitespace-only changes.

src/useDynamicTabs/createDefaultOptions.js renamed to src/utils/api/optionManager/defaultOptions.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
1-
const CreateDefaultOptions = function (fn, DefaulTabInnerComponent = null) {
2-
this.fn = fn;
1+
const DefaultOptions = function (DefaulTabInnerComponent = null) {
32
this.defaultDirection = 'ltr';
43
this._DefaulTabInnerComponent = DefaulTabInnerComponent;
54
this.directionsRange = ['ltr', 'rtl'];
6-
this._create(this._getOptions());
75
};
8-
CreateDefaultOptions.prototype._create = function (options) {
9-
this.fn.options = options;
6+
DefaultOptions.prototype.getOptions = function () {
7+
return this._getOptions();
108
};
11-
CreateDefaultOptions.prototype._getOptions = function () {
9+
DefaultOptions.prototype._getOptions = function () {
1210
const _options = {
1311
tabs: [],
1412
selectedTabID: '',
@@ -50,4 +48,4 @@ CreateDefaultOptions.prototype._getOptions = function () {
5048
});
5149
return _options;
5250
};
53-
export default CreateDefaultOptions;
51+
export default DefaultOptions;
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import factory from './optionManager.factory.js';
2-
import useDynamicTabs from '../../../useDynamicTabs/index.js';
2+
import DefaultTabInnerComponent from '../../../tab/defaulTabInner.js';
3+
import DefaultOptions from './DefaultOptions.js';
34
const getDeps = function () {
4-
const globalDefaultOptions = useDynamicTabs.options;
5+
const globalDefaultOptions = new (DefaultOptions)(DefaultTabInnerComponent).getOptions();
56
return { globalDefaultOptions };
67
};
78
export default factory.bind(null, getDeps);

0 commit comments

Comments
 (0)