Merge pull request oracle-samples#44 from metamemelord/ol8-example

Moved imagedims to OL8 base image

Author: sachin-pikle

samples/imagedims-python/Dockerfile

@@ -1,15 +1,21 @@
 FROM fnproject/python:3.6-dev as build-stage
 WORKDIR /function
 ADD requirements.txt /function/
+
 RUN pip3 install --target /python/  --no-cache --no-cache-dir -r requirements.txt &&\
-	rm -fr ~/.cache/pip /tmp* requirements.txt func.yaml Dockerfile .venv
+  rm -fr ~/.cache/pip /tmp* requirements.txt func.yaml Dockerfile .venv &&\
+  chmod -R o+r /python
 ADD . /function/
 RUN rm -fr /function/.pip_cache
 
 FROM fnproject/python:3.6
-RUN apt-get update && apt-get install -y imagemagick
+RUN microdnf install oracle-epel-release-el8 &&\
+      microdnf install ImageMagick &&\
+      microdnf remove oracle-epel-release-el8 &&\
+      microdnf clean all
 WORKDIR /function
-COPY --from=build-stage /function /function
 COPY --from=build-stage /python /python
-ENV PYTHONPATH=/python
+COPY --from=build-stage /function /function
+RUN chmod -R o+r /function
+ENV PYTHONPATH=/function:/python
 ENTRYPOINT ["/python/bin/fdk", "/function/func.py", "handler"]

samples/imagedims-python/README.md

@@ -61,35 +61,40 @@ Python 3.6 function container image looks like this:
 FROM fnproject/python:3.6-dev as build-stage
 WORKDIR /function
 ADD requirements.txt /function/
+
 RUN pip3 install --target /python/  --no-cache --no-cache-dir -r requirements.txt &&\
-	rm -fr ~/.cache/pip /tmp* requirements.txt func.yaml Dockerfile .venv
+  rm -fr ~/.cache/pip /tmp* requirements.txt func.yaml Dockerfile .venv &&\
+  chmod -R o+r /python
 ADD . /function/
 RUN rm -fr /function/.pip_cache
-
 FROM fnproject/python:3.6
 WORKDIR /function
-COPY --from=build-stage /function /function
 COPY --from=build-stage /python /python
-ENV PYTHONPATH=/python
+COPY --from=build-stage /function /function
+RUN chmod -R o+r /function
+ENV PYTHONPATH=/function:/python
 ENTRYPOINT ["/python/bin/fdk", "/function/func.py", "handler"]
 ```
 
-It's a two stage build with the *fnproject/python:3.6-dev* image containing *pip* and
-other build tools, and the *fnproject/python:3.6* image containing just the Python
-runtime.  This approach is designed to ensure that deployable function container
+It's a two stage build with the first stage containing python with build tools
+and the second stage with only the python runtime and minimum required dependencies.
+This approach is designed to ensure that deployable function container
 images are as small as possible, which is beneficial for a number of reasons
 including the time it takes to transfer the image from a Docker respository to
 the compute node where the function is to be run.
 
-The *fnproject/python* container image is built on Debian so we'll need to install
+The *fnproject/python:3.6* container image needs ImageMagick from the EPEL repo, so we'll need to install
 the
-[ImageMagick Debian package](https://packages.debian.org/buster/imagemagick)
-using the *apt-get* package management utility.
+[ImageMagick package](https://yum.oracle.com/repo/OracleLinux/OL8/developer/EPEL/x86_64/index.html)
+using the *microdnf* package management utility.
 ```Dockerfile
-RUN apt-get update && apt-get install -y imagemagick
+RUN microdnf install oracle-epel-release-el8 &&\
+      microdnf install ImageMagick &&\
+      microdnf remove oracle-epel-release-el8 &&\
+      microdnf clean all
 ```
-We want to install ImageMagick into the runtime image, not the build image,
-so we need to add the *RUN* command after the *FROM fnproject/python:3.6* line.
+We want to install ImageMagick into the runtime image, not the build image, so we need to 
+add the above lines in the second stage as shown in the merged [Dockerfile](./Dockerfile).
 
 
 ## Deploy the function
@@ -132,3 +137,4 @@ possible to customize your function's runtime environment including letting you
 install any Linux libraries or utilities that your function might need. And
 thanks to the Fn CLI's support for Dockerfiles it's the same user experience as
 when developing any function.
+