tests/examples/find-global-state: don't report const arrays

Author: davidmalcolm

tests/examples/find-global-state/input.c

@@ -17,6 +17,8 @@
    <http://www.gnu.org/licenses/>.
 */
 
+#include <stdio.h>
+
 static int a_global;
 
 struct {
@@ -39,3 +41,9 @@ int test2(int j)
   i += j;
   return j * i;
 }
+
+int test3(int k)
+{
+  /* We should *not* report about __FUNCTION__ here: */
+  printf("%s:%i:%s\n", __FILE__, __LINE__, __FUNCTION__);
+}

tests/examples/find-global-state/script.py

@@ -21,9 +21,19 @@
 def on_pass_execution(p, fn):
     if p.name == '*free_lang_data':
         for var in gcc.get_variables():
+            type_ = var.decl.type
+
+            # Don't bother warning about an array of const e.g.
+            # const char []
+            if isinstance(type_, gcc.ArrayType):
+                item_type = type_.dereference
+                if hasattr(item_type, 'const'):
+                    if item_type.const:
+                        continue
+
             gcc.inform(var.decl.location,
                        'global state "%s %s" defined here'
-                       % (var.decl.type, var.decl))
+                       % (type_, var.decl))
 
 gcc.register_callback(gcc.PLUGIN_PASS_EXECUTION,
                       on_pass_execution)

tests/examples/find-global-state/stderr.txt

@@ -1,6 +1,6 @@
-tests/examples/find-global-state/input.c:38:14: note: global state "int i" defined here
-tests/examples/find-global-state/input.c:24:3: note: global state "struct 
+tests/examples/find-global-state/input.c:40:14: note: global state "int i" defined here
+tests/examples/find-global-state/input.c:26:3: note: global state "struct 
 {
   int i;
 } bar" defined here
-tests/examples/find-global-state/input.c:20:12: note: global state "int a_global" defined here
+tests/examples/find-global-state/input.c:22:12: note: global state "int a_global" defined here