From 5d82183061bdb73a1910dae14cf82efe00557286 Mon Sep 17 00:00:00 2001 From: Sung Won Chung Date: Wed, 20 Dec 2023 09:19:10 -0800 Subject: [PATCH 1/3] add vhol callout --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index fb422a47..4f386429 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,8 @@ data-diff: Compare datasets fast, within or across SQL databases
+> [Make sure to join us at our virtual hands-on lab series where our team walks through live how to get set-up with it!](https://www.datafold.com/virtual-hands-on-lab) + # Use Cases ## Data Migration & Replication Testing From d778266d1a1285ce7919c633c80324a393a52264 Mon Sep 17 00:00:00 2001 From: Sung Won Chung Date: Wed, 20 Dec 2023 15:22:45 -0800 Subject: [PATCH 2/3] remove vs code language --- README.md | 2 -- data_diff/dbt.py | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4f386429..1a0f1ba9 100644 --- a/README.md +++ b/README.md @@ -45,8 +45,6 @@ Test SQL code and preview changes by comparing development/staging environment d **[Get started with data-diff & dbt](https://docs.datafold.com/development_testing/open_source)** -Also available in a [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=Datafold.datafold-vscode) - Reach out on the dbt Slack in [#tools-datafold](https://getdbt.slack.com/archives/C03D25A92UU) for advice and support diff --git a/data_diff/dbt.py b/data_diff/dbt.py index ef780429..8797f7b0 100644 --- a/data_diff/dbt.py +++ b/data_diff/dbt.py @@ -50,7 +50,7 @@ logger = getLogger(__name__) CLOUD_DOC_URL = "https://docs.datafold.com/development_testing/cloud" -EXTENSION_INSTALL_URL = "https://get.datafold.com/datafold-vs-code-install" +DATAFOLD_TRIAL_URL = "https://docs.datafold.com/development_testing/datafold_cloud" class TDiffVars(pydantic.BaseModel): @@ -559,5 +559,5 @@ def _email_signup() -> None: def _extension_notification() -> None: if bool_notify_about_extension(): rich.print( - f"\n\nHaving a good time diffing? :heart_eyes-emoji:\nMake sure to check out the free [bold]Datafold VS Code extension[/bold] for more a more seamless diff experience:\n{EXTENSION_INSTALL_URL}" + f"\n\nHaving a good time diffing? Make sure to check out the free Datafold Cloud Trial for an evolved experience including value-level diffs and column level lineage:\n{DATAFOLD_TRIAL_URL}" ) From eab9df6203dc5a70f6502046d0c955fdb58eac51 Mon Sep 17 00:00:00 2001 From: Sung Won Chung Date: Thu, 21 Dec 2023 09:56:03 -0800 Subject: [PATCH 3/3] improve guidance --- data_diff/dbt.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/data_diff/dbt.py b/data_diff/dbt.py index 8797f7b0..92a1fdbe 100644 --- a/data_diff/dbt.py +++ b/data_diff/dbt.py @@ -8,6 +8,7 @@ import pydantic import rich from rich.prompt import Prompt +from rich.markdown import Markdown from concurrent.futures import ThreadPoolExecutor, as_completed from data_diff.errors import ( @@ -50,7 +51,8 @@ logger = getLogger(__name__) CLOUD_DOC_URL = "https://docs.datafold.com/development_testing/cloud" -DATAFOLD_TRIAL_URL = "https://docs.datafold.com/development_testing/datafold_cloud" +DATAFOLD_TRIAL_URL = "https://app.datafold.com/org-signup" +DATAFOLD_INSTRUCTIONS_URL = "https://docs.datafold.com/development_testing/datafold_cloud" class TDiffVars(pydantic.BaseModel): @@ -558,6 +560,8 @@ def _email_signup() -> None: def _extension_notification() -> None: if bool_notify_about_extension(): - rich.print( - f"\n\nHaving a good time diffing? Make sure to check out the free Datafold Cloud Trial for an evolved experience including value-level diffs and column level lineage:\n{DATAFOLD_TRIAL_URL}" - ) + message = "\n\nHaving a good time diffing?\n\nMake sure to check out the free Datafold Cloud Trial for an evolved experience:\n\n- value-level diffs\n- column-level lineage\n" + rich.print(message) + rich.print(Markdown(f"[Sign Up Here]({DATAFOLD_TRIAL_URL})")) + rich.print("") + rich.print(Markdown(f"[Follow the instructions to get started]({DATAFOLD_INSTRUCTIONS_URL})"))