Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit 95968c5

Browse files
committed
clarifying comment
1 parent c9d1db0 commit 95968c5

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

data_diff/databases/databricks.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,10 @@ def query_table_schema(self, path: DbPath) -> Dict[str, tuple]:
148148
logging.warning("Failed to get schema from information_schema, falling back to legacy approach.")
149149

150150
if not table_schema:
151+
# This legacy approach can cause bugs. e.g. VARCHAR(255) -> VARCHAR(255)
152+
# and not the expected VARCHAR
153+
154+
# I don't think we'll fall back to this approach, but if so, see above
151155
catalog, schema, table = self._normalize_table_path(path)
152156
with conn.cursor() as cursor:
153157
cursor.columns(catalog_name=catalog, schema_name=schema, table_name=table)

0 commit comments

Comments
 (0)