Skip to content

Commit 192901a

Browse files
authored
Don't let Column.name be None (#223)
* unnunnable-ify name * allow default empty string name * optionality * fixup
1 parent e9ae6a3 commit 192901a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

spec/API_specification/dataframe_api/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def concat(dataframes: Sequence[DataFrame]) -> DataFrame:
6363
"""
6464
...
6565

66-
def column_from_sequence(sequence: Sequence[Any], *, name: str | None, dtype: Any) -> Column[Any]:
66+
def column_from_sequence(sequence: Sequence[Any], *, dtype: Any, name: str = '') -> Column[Any]:
6767
"""
6868
Construct Column from sequence of elements.
6969
@@ -109,7 +109,7 @@ def dataframe_from_dict(data: Mapping[str, Column[Any]]) -> DataFrame:
109109
...
110110

111111

112-
def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
112+
def column_from_1d_array(array: Any, *, dtype: Any, name: str = '') -> Column[Any]:
113113
"""
114114
Construct Column from 1D array.
115115
@@ -123,7 +123,7 @@ def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
123123
----------
124124
array : array
125125
array-API compliant 1D array
126-
name : str
126+
name : str, optional
127127
Name to give columns.
128128
dtype : DType
129129
Dtype of column.

spec/API_specification/dataframe_api/column_object.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def column(self) -> Any:
4747
...
4848

4949
@property
50-
def name(self) -> str | None:
50+
def name(self) -> str:
5151
"""Return name of column."""
5252

5353
def __len__(self) -> int:
@@ -724,7 +724,7 @@ def to_array_object(self, dtype: Any) -> Any:
724724
``array-api-compat`` package to convert it to a Standard-compliant array.
725725
"""
726726

727-
def rename(self, name: str | None) -> Column[DType]:
727+
def rename(self, name: str) -> Column[DType]:
728728
"""
729729
Rename column.
730730

0 commit comments

Comments
 (0)