From 85f99f0a82de293e3aa7295e7313166dbc041d3d Mon Sep 17 00:00:00 2001 From: lezcano Date: Wed, 14 Jul 2021 10:59:48 +0100 Subject: [PATCH 1/2] Remove upper keyword --- spec/extensions/linear_algebra_functions.md | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/spec/extensions/linear_algebra_functions.md b/spec/extensions/linear_algebra_functions.md index 423e17b85..7b8819377 100644 --- a/spec/extensions/linear_algebra_functions.md +++ b/spec/extensions/linear_algebra_functions.md @@ -180,7 +180,7 @@ Returns the specified diagonals. If `x` has more than two dimensions, then the a _TODO: this requires complex number support to be added to the specification._ (function-linalg-eigh)= -### linalg.eigh(x, /, *, upper=False) +### linalg.eigh(x) Returns the eigenvalues and eigenvectors of a symmetric matrix (or a stack of symmetric matrices) `x`. @@ -192,10 +192,6 @@ Returns the eigenvalues and eigenvectors of a symmetric matrix (or a stack of sy - input array having shape `(..., M, M)` and whose innermost two dimensions form square matrices. Must have a floating-point data type. -- **upper**: _bool_ - - - If `True`, use the upper-triangular part to compute the eigenvalues and eigenvectors. If `False`, use the lower-triangular part to compute the eigenvalues and eigenvectors. Default: `False`. - #### Returns - **out**: _Tuple\[ <array> ]_ @@ -218,7 +214,7 @@ Eigenvalue sort order is left unspecified. _TODO: this requires complex number support to be added to the specification._ (function-linalg-eigvalsh)= -### linalg.eigvalsh(x, /, *, upper=False) +### linalg.eigvalsh(x) Computes the eigenvalues of a symmetric matrix (or a stack of symmetric matrices) `x`. @@ -230,10 +226,6 @@ Computes the eigenvalues of a symmetric matrix (or a stack of symmetric matrices - input array having shape `(..., M, M)` and whose innermost two dimensions form square matrices. Must have a floating-point data type. -- **upper**: _bool_ - - - If `True`, use the upper-triangular part to compute the eigenvalues. If `False`, use the lower-triangular part to compute the eigenvalues. Default: `False`. - #### Returns - **out**: _<array>_ @@ -648,4 +640,4 @@ Alias for {ref}`function-transpose`. (function-linalg-vecdot)= ### linalg.vecdot(x1, x2, /, *, axis=None) -Alias for {ref}`function-vecdot`. \ No newline at end of file +Alias for {ref}`function-vecdot`. From 9fcf96e19fef2c8d3de3c56f7742fa3ff10471de Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 15 Jul 2021 09:29:55 -0700 Subject: [PATCH 2/2] Ensure arguments are positional-only --- spec/extensions/linear_algebra_functions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/extensions/linear_algebra_functions.md b/spec/extensions/linear_algebra_functions.md index 7b8819377..9816f275d 100644 --- a/spec/extensions/linear_algebra_functions.md +++ b/spec/extensions/linear_algebra_functions.md @@ -180,7 +180,7 @@ Returns the specified diagonals. If `x` has more than two dimensions, then the a _TODO: this requires complex number support to be added to the specification._ (function-linalg-eigh)= -### linalg.eigh(x) +### linalg.eigh(x, /) Returns the eigenvalues and eigenvectors of a symmetric matrix (or a stack of symmetric matrices) `x`. @@ -214,7 +214,7 @@ Eigenvalue sort order is left unspecified. _TODO: this requires complex number support to be added to the specification._ (function-linalg-eigvalsh)= -### linalg.eigvalsh(x) +### linalg.eigvalsh(x, /) Computes the eigenvalues of a symmetric matrix (or a stack of symmetric matrices) `x`.