Skip to content

Commit 3350625

Browse files
committed
Refactor to use fetch
1 parent 281d236 commit 3350625

File tree

1 file changed

+18
-15
lines changed

1 file changed

+18
-15
lines changed

spec/_static/javascripts/version_dropdown.js

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,20 @@ async function add_version_dropdown(json_loc, target_loc, text) {
5858
dropdown.appendChild(button);
5959
dropdown.appendChild(content);
6060

61-
const p = $.getJSON(json_loc);
62-
console.log(p);
61+
const opts = {
62+
'method': 'GET'
63+
};
64+
await fetch(json_loc, opts).then(onResponse).then(onVersions).catch(onError);
6365

64-
p.then(onVersions);
65-
p.fail(onFail).always(onAlways);
66-
67-
await p.promise();
66+
/**
67+
* Callback invoked upon resolving a resource.
68+
*
69+
* @private
70+
* @param {Object} response - response object
71+
*/
72+
function onResponse(response) {
73+
return response.json();
74+
}
6875

6976
/**
7077
* Callback invoked upon resolving a JSON resource.
@@ -113,24 +120,20 @@ async function add_version_dropdown(json_loc, target_loc, text) {
113120
}
114121
// Set the button text:
115122
button.innerHTML = text;
123+
124+
// Append dropdown:
125+
$(".navheader").append(dropdown);
116126
}
117127

118128
/**
119-
* Callback invoked upon failing to resolve a JSON resource.
129+
* Callback invoked upon failing to resolve a resource.
120130
*
121131
* @private
122132
*/
123133
function onFail() {
124134
button.innerHTML = "Other Versions Not Found";
125-
}
126135

127-
/**
128-
* Callback which is always invoked upon attempting to resolve a JSON resource.
129-
*
130-
* @private
131-
*/
132-
function onAlways() {
133-
console.log("Always");
136+
// Append dropdown:
134137
$(".navheader").append(dropdown);
135138
}
136139
};

0 commit comments

Comments
 (0)