Skip to content

Commit 958d5c5

Browse files
committed
Comment out a slotdet test that doesn't hold exactly
1 parent b2fdefd commit 958d5c5

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

array_api_tests/test_linalg.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,10 +464,12 @@ def test_slogdet(x):
464464

465465
# Check that when the determinant is 0, the sign and logabsdet are (0,
466466
# -inf).
467-
d = linalg.det(x)
468-
zero_det = equal(d, zero(d.shape, d.dtype))
469-
assert_exactly_equal(sign[zero_det], zero(sign[zero_det].shape, x.dtype))
470-
assert_exactly_equal(logabsdet[zero_det], -infinity(logabsdet[zero_det].shape, x.dtype))
467+
# TODO: This test does not necessarily hold exactly. Update it to test it
468+
# approximately.
469+
# d = linalg.det(x)
470+
# zero_det = equal(d, zero(d.shape, d.dtype))
471+
# assert_exactly_equal(sign[zero_det], zero(sign[zero_det].shape, x.dtype))
472+
# assert_exactly_equal(logabsdet[zero_det], -infinity(logabsdet[zero_det].shape, x.dtype))
471473

472474
# More generally, det(x) should equal sign*exp(logabsdet), but this does
473475
# not hold exactly due to floating-point loss of precision.

0 commit comments

Comments
 (0)