Skip to content

Commit e5225ed

Browse files
committed
Parameterize the API version in a loop instead of in the matrix
1 parent 44bbdb2 commit e5225ed

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

.github/workflows/array-api-tests.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on: [push, pull_request]
44

55
env:
66
PYTEST_ARGS: "-v -rxXfE --ci --hypothesis-disable-deadline --max-examples 200"
7+
API_VERSIONS: "2022.12 2023.12"
78

89
jobs:
910
array-api-tests:
@@ -12,7 +13,6 @@ jobs:
1213
matrix:
1314
python-version: ['3.9', '3.10', '3.11', '3.12']
1415
numpy-version: ['1.26', 'dev']
15-
api_version: ['2022.12', '2023.12']
1616
exclude:
1717
- python-version: '3.8'
1818
numpy-version: 'dev'
@@ -50,12 +50,13 @@ jobs:
5050
# tests fail in numpy 1.26 on bad scalar type promotion behavior)
5151
NPY_PROMOTION_STATE: weak
5252
run: |
53-
export ARRAY_API_STRICT_API_VERSION=${{ matrix.api_version }}
53+
# Parameterizing this in the CI matrix is wasteful. Just do a loop here.
54+
for ARRAY_API_STRICT_API_VERSION in ${API_VERSIONS}; do
55+
# Only signature tests work for now for 2023.12
56+
if [[ "$ARRAY_API_STRICT_API_VERSION" == "2023.12" ]]; then
57+
PYTEST_ARGS="${PYTEST_ARGS} -k signature
58+
fi
5459
55-
# Only signature tests work for now for 2023.12
56-
if [[ "${{ matrix.api_version }}" == "2023.12" ]]; then
57-
PYTEST_ARGS="${PYTEST_ARGS} -k signature
58-
fi
59-
60-
cd ${GITHUB_WORKSPACE}/array-api-tests
61-
pytest array_api_tests/ --skips-file ${GITHUB_WORKSPACE}/array-api-strict/array-api-tests-xfails.txt ${PYTEST_ARGS}
60+
cd ${GITHUB_WORKSPACE}/array-api-tests
61+
pytest array_api_tests/ --skips-file ${GITHUB_WORKSPACE}/array-api-strict/array-api-tests-xfails.txt ${PYTEST_ARGS}
62+
done

0 commit comments

Comments
 (0)