enable copy=False

Original NumPy Commit: 6535f88db0af9f881ab3b410ccf71c8531f6afb5

Author: bwalshe

array_api_strict/_manipulation_functions.py

@@ -63,14 +63,17 @@ def reshape(x: Array,
 
     See its docstring for more information.
     """
-    if copy is False:
-        raise NotImplementedError("copy=False is not yet implemented")
 
     data = x._array
     if copy:
         data = np.copy(data)
 
-    return Array._new(np.reshape(data, shape))
+    reshaped = np.reshape(data, shape)
+
+    if copy is False and not np.shares_memory(data, reshaped):
+        raise AttributeError("Incompatible shape for in-place modification.")
+
+    return Array._new(reshaped)
 
 
 def roll(

array_api_strict/tests/test_manipulation_functions.py

@@ -23,10 +23,15 @@ def test_stack_errors():
 
 
 def test_reshape_copy():
-    a = asarray([1])
-    b = reshape(a, (1, 1), copy=True)
-    a[0] = 0
-    assert all(b[0, 0] == 1)
-    assert all(a[0] == 0)
-    assert_raises(NotImplementedError, lambda: reshape(a, (1, 1), copy=False))
+    a = asarray(np.ones((2,3)))
+    b = reshape(a, (3, 2), copy=True)
+    assert not np.shares_memory(a._array, b._array)
+    
+    a = asarray(np.ones((2,3)))
+    b = reshape(a, (3, 2), copy=False)
+    assert np.shares_memory(a._array, b._array)
+
+    a = asarray(np.ones((2,3)).T)
+    b = reshape(a, (3, 2), copy=True)
+    assert_raises(AttributeError, lambda: reshape(a, (2, 3), copy=False))