From ba00acf6c737228c596cbff836a9323b1ffbf14c Mon Sep 17 00:00:00 2001
From: Victor Berchet <victor@suumit.com>
Date: Wed, 23 Jul 2014 16:29:29 +0200
Subject: [PATCH] perf(dccd): Drop useless checks

in _recordAdd(), previous could never be null as the list is never empty
(it has at least a marker).
in _recordRemove(), when the list is composed of a single record, it
must be the record we're trying to remove (and we assert that).
---
 lib/change_detection/dirty_checking_change_detector.dart | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/change_detection/dirty_checking_change_detector.dart b/lib/change_detection/dirty_checking_change_detector.dart
index c927ff9dd..c403f0185 100644
--- a/lib/change_detection/dirty_checking_change_detector.dart
+++ b/lib/change_detection/dirty_checking_change_detector.dart
@@ -175,12 +175,12 @@ class DirtyCheckingChangeDetectorGroup<H> implements ChangeDetectorGroup<H> {
 
   DirtyCheckingRecord _recordAdd(DirtyCheckingRecord record) {
     DirtyCheckingRecord previous = _recordTail;
-    DirtyCheckingRecord next = previous == null ? null : previous._nextRecord;
+    DirtyCheckingRecord next = previous._nextRecord;
 
     record._nextRecord = next;
     record._prevRecord = previous;
 
-    if (previous != null) previous._nextRecord = record;
+    previous._nextRecord = record;
     if (next != null) next._prevRecord = record;
 
     _recordTail = record;
@@ -194,7 +194,8 @@ class DirtyCheckingChangeDetectorGroup<H> implements ChangeDetectorGroup<H> {
     DirtyCheckingRecord previous = record._prevRecord;
     DirtyCheckingRecord next = record._nextRecord;
 
-    if (record == _recordHead && record == _recordTail) {
+    if (_recordHead == _recordTail) {
+      assert(record == _recordHead);
       // we are the last one, must leave marker behind.
       _recordHead = _recordTail = _marker;
       _marker._nextRecord = next;