Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

fix(ngModel): ensure that string-based inputs always provide string values to parsers #1640

Closed
wants to merge 1 commit into from
Closed

fix(ngModel): ensure that string-based inputs always provide string values to parsers #1640

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Jan 13, 2015

Closes #1587

rkirov
rkirov reviewed Jan 13, 2015
View reviewed changes
lib/directive/ng_model.dart
@@ -824,7 +836,9 @@ class InputRadio {
@Decorator(selector: '[contenteditable][ng-model]')
class ContentEditable extends InputTextLike {
ContentEditable(dom.Element inputElement, NgModel ngModel, Scope scope, NgModelOptions modelOptions)
: super(inputElement, ngModel, scope, modelOptions);
: super(inputElement, ngModel, scope, modelOptions) {
ngModel.stringBasedInput = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super call handles that.

@rkirov
Copy link
Contributor

rkirov commented Jan 14, 2015

See my comments #1587 I don't think this PR is needed.

@naomiblack naomiblack closed this Jan 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NgForm.reset() always set a null value if the NgModel has a converter
5 participants
@matsko @rkirov @mhevery @naomiblack @googlebot