fix(parser): ensure only one instance of dynamic parser

Author: chirayuk

bin/parser_generator_for_spec.dart

@@ -6,8 +6,8 @@ import 'package:angular/core/parser/parser.dart';
 import 'package:angular/tools/parser_getter_setter/generator.dart';
 
 main(arguments) {
-  Module module = new Module()..bind(Parser, toImplementation: DynamicParser);
-  module.bind(ParserBackend, toImplementation: DartGetterSetterGen);
+  Module module = new Module()..bind(Parser, toFactory: (i) => i.get(DynamicParser));
+  module.bind(ParserBackend, toFactory: (i) => i.get(DartGetterSetterGen));
   Injector injector = new DynamicInjector(modules: [module],
       allowImplicitInjection: true);
 

lib/core/module_internal.dart

@@ -48,8 +48,8 @@ class CoreModule extends Module {
     bind(Object, toValue: {}); // RootScope context
     bind(VmTurnZone);
 
-    bind(Parser, toImplementation: DynamicParser);
-    bind(ParserBackend, toImplementation: DynamicParserBackend);
+    bind(Parser, toFactory: (i) => i.get(DynamicParser));
+    bind(ParserBackend, toFactory: (i) => i.get(DynamicParserBackend));
     bind(DynamicParser);
     bind(DynamicParserBackend);
     bind(Lexer);

lib/tools/expression_extractor.dart

@@ -52,8 +52,8 @@ main(args) {
 
   printer.write('// Found ${expressions.length} expressions\n');
   Module module = new Module()
-      ..bind(Parser, toImplementation: DynamicParser)
-      ..bind(ParserBackend, toImplementation: DartGetterSetterGen);
+      ..bind(Parser, toFactory: (i) => i.get(DynamicParser))
+      ..bind(ParserBackend, toFactory: (i) => i.get(DartGetterSetterGen));
   Injector injector =
       new DynamicInjector(modules: [module], allowImplicitInjection: true);
 

lib/tools/transformer/expression_generator.dart

@@ -46,8 +46,8 @@ class ExpressionGenerator extends Transformer with ResolverTransformer {
         .forEach(htmlExtractor.parseHtml)
         .then((_) {
       var module = new Module()
-        ..bind(Parser, toImplementation: DynamicParser)
-        ..bind(ParserBackend, toImplementation: DartGetterSetterGen);
+        ..bind(Parser, toFactory: (i) => i.get(DynamicParser))
+        ..bind(ParserBackend, toFactory: (i) => i.get(DartGetterSetterGen));
       var injector =
           new DynamicInjector(modules: [module], allowImplicitInjection: true);
 

test/core/parser/generated_getter_setter_spec.dart

@@ -7,7 +7,7 @@ import 'generated_getter_setter.dart' as gen;
 main() {
   describe('hybrid getter-setter', () {
     beforeEachModule((Module module) {
-      module..bind(Parser, toImplementation: DynamicParser)
+      module..bind(Parser, toFactory: (i) => i.get(DynamicParser))
             ..bind(ClosureMap, toValue: gen.closureMap);
     });
     parser_spec.main();

test/core/parser/parser_spec.dart

@@ -56,6 +56,17 @@ main() {
       module.bind(SubstringFormatter);
     });
 
+    describe('DynamicParser', () {
+      // This is important because the DynamicParser expects to be a singleton
+      // to share its cache.  It therefore registers with the CacheRegister and
+      // having more than one instance will result in a duplicate registration.
+      it('should be identical to Parser in dynamic mode', (Parser p, DynamicParser dp) {
+        if (p is DynamicParser) {
+          expect(identical(p, dp)).toBeTruthy();;
+        }
+      });
+    });
+
     beforeEach((Parser injectedParser, FormatterMap injectedFormatters) {
       parser = injectedParser;
       formatters = injectedFormatters;