style: code cleanup

Author: vicb

lib/core_dom/view_factory.dart

@@ -129,7 +129,7 @@ class ViewCache {
   ViewFactory fromHtml(String html, DirectiveMap directives) {
     ViewFactory viewFactory = _viewFactoryCache.get(html);
     if (viewFactory == null) {
-      var div = new dom.Element.tag('div');
+      var div = new dom.DivElement();
       div.setInnerHtml(html, treeSanitizer: treeSanitizer);
       viewFactory = compiler(div.nodes, directives);
       _viewFactoryCache.put(html, viewFactory);

lib/directive/ng_base_css.dart

@@ -1,9 +1,6 @@
 part of angular.directive;
 
-@Decorator(
-    selector: '[ng-base-css]',
-    visibility: Directive.CHILDREN_VISIBILITY
-)
+@Decorator(selector: '[ng-base-css]')
 class NgBaseCss {
   List<String> _urls = const [];
 

lib/directive/ng_form.dart

@@ -7,24 +7,20 @@ part of angular.directive;
  */
 @Decorator(
     selector: 'form',
-    module: NgForm.module,
-    visibility: Directive.CHILDREN_VISIBILITY)
+    module: NgForm.module)
 @Decorator(
     selector: 'fieldset',
-    module: NgForm.module,
-    visibility: Directive.CHILDREN_VISIBILITY)
+    module: NgForm.module)
 @Decorator(
     selector: '.ng-form',
-    module: NgForm.module,
-    visibility: Directive.CHILDREN_VISIBILITY)
+    module: NgForm.module)
 @Decorator(
     selector: '[ng-form]',
     module: NgForm.module,
-    map: const { 'ng-form': '@name' },
-    visibility: Directive.CHILDREN_VISIBILITY)
+    map: const { 'ng-form': '@name' })
 class NgForm extends NgControl {
   static final Module _module = new Module()
-    ..factory(NgControl, (i) => i.get(NgForm), visibility: Directive.CHILDREN_VISIBILITY);
+      ..factory(NgControl, (i) => i.get(NgForm));
   static module() => _module;
 
   final Scope _scope;

lib/directive/ng_model_select.dart

@@ -18,8 +18,7 @@ part of angular.directive;
  *
  */
 @Decorator(
-    selector: 'select[ng-model]',
-    visibility: Directive.CHILDREN_VISIBILITY)
+    selector: 'select[ng-model]')
 class InputSelect implements AttachAware {
   final expando = new Expando<OptionValue>();
   final dom.SelectElement _selectElement;

lib/routing/ng_bind_route.dart

@@ -23,7 +23,6 @@ part of angular.routing;
  * however it does not effect view resolution by nested ng-view(s).
  */
 @Decorator(
-    visibility: Directive.CHILDREN_VISIBILITY,
     selector: '[ng-bind-route]',
     module: NgBindRoute.module,
     map: const {'ng-bind-route': '@routeName'})

lib/routing/routing.dart

@@ -21,7 +21,7 @@ class RouteViewFactory {
 
   _configure(Route route, Map<String, NgRouteCfg> config) {
     config.forEach((name, cfg) {
-      var moduledCalled = false;
+      var modulesCalled = false;
       List<Module> newModules;
       route.addRoute(
           name: name,
@@ -37,8 +37,8 @@ class RouteViewFactory {
             }
           },
           preEnter: (RoutePreEnterEvent e) {
-            if (cfg.modules != null && !moduledCalled) {
-              moduledCalled = true;
+            if (cfg.modules != null && !modulesCalled) {
+              modulesCalled = true;
               var modules = cfg.modules();
               if (modules is Future) {
                 e.allowEnter(modules.then((List<Module> m) {
@@ -92,10 +92,8 @@ class NgRouteCfg {
  *
  * The [init] method will be called by the framework once the router is
  * instantiated but before [NgBindRouteDirective] and [NgViewDirective].
- *
- * Deprecated: use RouteInitializerFn instead.
  */
-@deprecated
+@Deprecated("use RouteInitializerFn instead")
 abstract class RouteInitializer {
   void init(Router router, RouteViewFactory viewFactory);
 }
@@ -146,7 +144,7 @@ class NgRoutingHelper {
     router.listen(appRoot: _ngApp.element);
   }
 
-  _reloadViews({Route startingFrom}) {
+  void _reloadViews({Route startingFrom}) {
     var alreadyActiveViews = [];
     var activePath = router.activePath;
     if (startingFrom != null) {
@@ -169,16 +167,16 @@ class NgRoutingHelper {
     }
   }
 
-  _route(Route route, String template, {bool fromEvent, List<Module> modules,
+  void _route(Route route, String template, {bool fromEvent, List<Module> modules,
       String templateHtml}) {
     _templates[_routePath(route)] = new _View(template, templateHtml, modules);
   }
 
-  _registerPortal(NgView ngView) {
+  void _registerPortal(NgView ngView) {
     portals.add(ngView);
   }
 
-  _unregisterPortal(NgView ngView) {
+  void _unregisterPortal(NgView ngView) {
     portals.remove(ngView);
   }
 }

test/directive/ng_if_spec.dart

@@ -141,7 +141,7 @@ main() {
       compile(html);
       expect(element).toHaveText('content');
       element.querySelector('span').classes.remove('my-class');
-      expect(element.querySelector('span').classes.contains('my-class')).not.toBe(true);
+      expect(element.querySelector('span')).not.toHaveClass('my-class');
       rootScope.apply(() {
         rootScope.context['isVisible'] = false;
       });
@@ -150,7 +150,7 @@ main() {
         rootScope.context['isVisible'] = true;
       });
       // The newly inserted node should be a copy of the compiled state.
-      expect(element.querySelector('span').classes.contains('my-class')).toBe(true);
+      expect(element.querySelector('span')).toHaveClass('my-class');
     }
   );