Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit e83854a

Browse files
committed
Style, typo and iit fixes
1 parent 558f44c commit e83854a

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

lib/block.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ class Block implements ElementWrapper {
176176

177177
int prevInstantiatedCount;
178178
List<String> alreadyInstantiated = <String>[];
179-
// TODO(pavelgj): this is a workaround for the lack of direction
179+
// TODO(pavelgj): this is a workaround for the lack of directive
180180
// instantiation ordering. A better way is to sort directives in the
181181
// order they must be instantiated in.
182182
do {
@@ -202,8 +202,7 @@ class Block implements ElementWrapper {
202202

203203
}
204204
directives.add(directiveInstance);
205-
} catch (e,s) {
206-
var msg;
205+
} catch (e, s) {
207206
if (e is MirroredUncaughtExceptionError) {
208207
//TODO(misko): why is this here? Injector should never throw this exception
209208
throw e.exception_string + "\n ORIGINAL Stack trace:\n" + e.stacktrace.toString();

test/_specs.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ class SpecInjector {
150150
List<Module> modules = [new Module()..value(Expando, new Expando('specExpando'))];
151151

152152
module(Function fn) {
153-
Module module = new AngularModule();
154-
module.type(Log, Log);
155-
module.type(Logger, Logger);
153+
Module module = new AngularModule()
154+
..type(Log, Log)
155+
..type(Logger, Logger);
156156
modules.add(module);
157157
fn(module);
158158
}

test/compiler_spec.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,13 +498,13 @@ main() {
498498

499499
describe('controller scoping', () {
500500

501-
iit('shoud make controllers available to sibling and child controllers', inject((Compiler $compile, Scope $rootScope, Log log) {
501+
it('shoud make controllers available to sibling and child controllers', inject((Compiler $compile, Scope $rootScope, Log log) {
502502
var element = $('<tab local><pane local></pane><pane local></pane></tab>');
503503
$compile(element)(element)..attach($rootScope);
504504
expect(log.result()).toEqual('TabComponent-0; LocalAttrDirective-0; PaneComponent-1; LocalAttrDirective-0; PaneComponent-2; LocalAttrDirective-0');
505505
}));
506506

507-
iit('should throw an exception if required directive is missing', inject((Compiler $compile, Scope $rootScope) {
507+
it('should throw an exception if required directive is missing', inject((Compiler $compile, Scope $rootScope) {
508508
expect(() {
509509
var element = $('<tab local><pane></pane><pane local></pane></tab>');
510510
$compile(element)(element)..attach($rootScope);

0 commit comments

Comments
 (0)