Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 3e21486

Browse files
vicbmhevery
authored andcommitted
style(ng-repeat): fix a typo shalow -> shallow (fix #581)
Fixes #581
1 parent 8f020f9 commit 3e21486

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

lib/directive/module.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class NgDirectiveModule extends Module {
4848
value(NgIncludeDirective, null);
4949
value(NgPluralizeDirective, null);
5050
value(NgRepeatDirective, null);
51-
value(NgShalowRepeatDirective, null);
51+
value(NgShallowRepeatDirective, null);
5252
value(NgShowDirective, null);
5353
value(InputTextLikeDirective, null);
5454
value(InputNumberLikeDirective, null);

lib/directive/ng_repeat.dart

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ class NgRepeatDirective extends AbstractNgRepeatDirective {
8686
Parser parser,
8787
Scope scope): super(blockHole, boundBlockFactory, parser, scope);
8888
get _shalow => false;
89+
90+
get _shallow => false;
8991
}
9092

9193
/**
@@ -110,13 +112,13 @@ class NgRepeatDirective extends AbstractNgRepeatDirective {
110112
children: NgAnnotation.TRANSCLUDE_CHILDREN,
111113
selector: '[ng-shallow-repeat]',
112114
map: const {'.': '@expression'})
113-
class NgShalowRepeatDirective extends AbstractNgRepeatDirective {
114-
NgShalowRepeatDirective(BlockHole blockHole,
115-
BoundBlockFactory boundBlockFactory,
116-
Parser parser,
117-
Scope scope)
115+
class NgShallowRepeatDirective extends AbstractNgRepeatDirective {
116+
NgShallowRepeatDirective(BlockHole blockHole,
117+
BoundBlockFactory boundBlockFactory,
118+
Parser parser,
119+
Scope scope)
118120
: super(blockHole, boundBlockFactory, parser, scope);
119-
get _shalow => true;
121+
get _shallow => true;
120122
}
121123

122124
abstract class AbstractNgRepeatDirective {
@@ -139,7 +141,7 @@ abstract class AbstractNgRepeatDirective {
139141

140142
AbstractNgRepeatDirective(this._blockHole, this._boundBlockFactory, this._parser, this._scope);
141143

142-
get _shalow;
144+
get _shallow;
143145

144146
set expression(value) {
145147
_expression = value;
@@ -174,7 +176,7 @@ abstract class AbstractNgRepeatDirective {
174176
_keyIdentifier = match.group(2);
175177

176178
_removeWatch = _scope.$watchCollection(_listExpr, _onCollectionChange,
177-
value, _shalow);
179+
value, _shallow);
178180
}
179181

180182
List<_Row> _computeNewRows(Iterable collection, trackById) {
@@ -255,7 +257,7 @@ abstract class AbstractNgRepeatDirective {
255257
previousNode = row.endNode;
256258
} else {
257259
// new item which we don't know about
258-
childScope = _scope.$new(lazy:_shalow);
260+
childScope = _scope.$new(lazy: _shallow);
259261
}
260262

261263
if (!identical(childScope[_valueIdentifier], value)) {

test/directive/ng_repeat_spec.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ main() {
394394
});
395395
});
396396

397-
describe('shalow', () {
397+
describe('shallow', () {
398398
TestBed _;
399399
beforeEach(inject((TestBed tb) => _ = tb));
400400

0 commit comments

Comments
 (0)