fix: replace sourcemap's path by the corresponding absolute file path #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
reviewed
Jun 27, 2019
| @@ -1,3 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
haha, you don't like my color theme for this repo
There was a problem hiding this comment.
Haha I didn't hate it, I just assumed it had been committed by mistake :p
|
ok, love it, will see if this fixes it, thank you @rndmerle |
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Yup, I think this is it - you can see the coverage info for Vue files now https://coveralls.io/github/bahmutov/code-coverage-vue-example |
|
Nice :) |
|
absolutely, the code coverage does look nice, but right now I am looking
more at the ways to combine frontend and backend code coverage like this
example https://github.com/cypress-io/cypress-example-realworld
…On Thu, Jun 27, 2019 at 4:09 PM Renaud Merle ***@***.***> wrote:
Nice :)
If I ever get the coverage working for code I'll let you know.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#23?email_source=notifications&email_token=AAQ4BJSMVPHFN3XWSO3FC2DP4UM7HA5CNFSM4H3M7UZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYHJLI#issuecomment-506492077>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQ4BJSQYCZFZHIIMW3OAB3P4UM7HANCNFSM4H3M7UZQ>
.
--
Dr. Gleb Bahmutov, PhD
Schedule video chat / phone call / meeting with me via
https://calendly.com/bahmutov
gleb.bahmutov@gmail.com @bahmutov <https://twitter.com/@bahmutov>
https://glebbahmutov.com/ https://glebbahmutov.com/blog
https://github.com/bahmutov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow-up on #17 comments.
I'm not sure it's the best way to proceed tho.
It should work on https://github.com/bahmutov/code-coverage-vue-example.
I also tried really hard to make coverage work for code (through generated render function) but in the end I think it can't work until vuejs/vue-loader#1400 is resolved so we get two distinct source-map entries for template and script parts.