Skip to content

Commit d140770

Browse files
committed
fixed another case for #469. Hopefully it's finally correct...
1 parent ae73ed0 commit d140770

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

custom_components/pyscript/eval.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,16 +1698,16 @@ async def ast_boolop(self, arg):
16981698
if isinstance(arg.op, ast.And):
16991699
val = True
17001700
for arg1 in arg.values:
1701-
this_val = await self.aeval(arg1)
1702-
if not this_val:
1703-
return this_val
1704-
val = this_val
1701+
val = await self.aeval(arg1)
1702+
if not val:
1703+
return val
17051704
return val
1705+
val = False
17061706
for arg1 in arg.values:
17071707
val = await self.aeval(arg1)
17081708
if val:
17091709
return val
1710-
return False
1710+
return val
17111711

17121712
async def eval_elt_list(self, elts):
17131713
"""Evaluate and star list elements."""

tests/test_unit_eval.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
["False or True", True],
5757
["False or False", False],
5858
["isinstance(False or False, bool)", True],
59+
["isinstance(False or 0, int)", True],
5960
["f'{1} {2:02d} {3:.1f}'", "1 02 3.0"],
6061
[["x = None", "x is None"], True],
6162
["None is not None", False],

0 commit comments

Comments
 (0)