Merge branch 'douglasduteil-style-enforce-single-quotes-eslint-rule'

Author: sokra

.eslintrc

@@ -1,5 +1,9 @@
 {
   "env": {
     "node": true
+  },
+  "rules": {
+    "strict": [2, "never"],
+    "quotes": [2, "single"]
   }
 }

index.js

@@ -12,23 +12,23 @@ function normalizeNodeArray(nodes) {
       array.push(x);
     }
   });
-  if(array.length > 0 && array[array.length - 1].type === "spacing") {
+  if(array.length > 0 && array[array.length - 1].type === 'spacing') {
     array.pop();
   }
   return array;
 }
 
 function localizeNode(node, context) {
-  if(context.ignoreNextSpacing && node.type !== "spacing") {
-    throw new Error("Missing whitespace after :" + context.ignoreNextSpacing);
+  if(context.ignoreNextSpacing && node.type !== 'spacing') {
+    throw new Error('Missing whitespace after :' + context.ignoreNextSpacing);
   }
-  if(context.enforceNoSpacing && node.type === "spacing") {
-    throw new Error("Missing whitespace before :" + context.enforceNoSpacing);
+  if(context.enforceNoSpacing && node.type === 'spacing') {
+    throw new Error('Missing whitespace before :' + context.enforceNoSpacing);
   }
 
   var newNodes;
   switch(node.type) {
-    case "selectors":
+    case 'selectors':
       var resultingGlobal;
       context.hasPureGlobals = false;
       newNodes = node.nodes.map(function(n) {
@@ -39,11 +39,11 @@ function localizeNode(node, context) {
           explicit: false
         };
         n = localizeNode(n, nContext);
-        if(typeof resultingGlobal === "undefined") {
+        if(typeof resultingGlobal === 'undefined') {
           resultingGlobal = nContext.global;
         } else if(resultingGlobal !== nContext.global) {
-          throw new Error("Inconsistent rule global/local result in rule '" +
-            Tokenizer.stringify(node) + "' (multiple selectors must result in the same mode for the rule)");
+          throw new Error('Inconsistent rule global/local result in rule "' +
+            Tokenizer.stringify(node) + '" (multiple selectors must result in the same mode for the rule)');
         }
         if(!nContext.hasLocals) {
           context.hasPureGlobals = true;
@@ -55,15 +55,15 @@ function localizeNode(node, context) {
       node.nodes = normalizeNodeArray(newNodes);
       break;
 
-    case "selector":
+    case 'selector':
       newNodes = node.nodes.map(function(n) {
         return localizeNode(n, context);
       });
       node = Object.create(node);
       node.nodes = normalizeNodeArray(newNodes);
       break;
 
-    case "spacing":
+    case 'spacing':
       if(context.ignoreNextSpacing) {
         context.ignoreNextSpacing = false;
         context.lastWasSpacing = false;
@@ -73,27 +73,27 @@ function localizeNode(node, context) {
       context.lastWasSpacing = true;
       return node;
 
-    case "pseudo-class":
-      if(node.name === "local" || node.name === "global") {
+    case 'pseudo-class':
+      if(node.name === 'local' || node.name === 'global') {
         if(context.inside) {
-          throw new Error("A :" + node.name + " is not allowed inside of a :" + context.inside + "(...)");
+          throw new Error('A :' + node.name + ' is not allowed inside of a :' + context.inside + '(...)');
         }
         context.ignoreNextSpacing = context.lastWasSpacing ? node.name : false;
         context.enforceNoSpacing = context.lastWasSpacing ? false : node.name;
-        context.global = (node.name === "global");
+        context.global = (node.name === 'global');
         context.explicit = true;
         return null;
       }
       break;
 
-    case "nested-pseudo-class":
+    case 'nested-pseudo-class':
       var subContext;
-      if(node.name === "local" || node.name === "global") {
+      if(node.name === 'local' || node.name === 'global') {
         if(context.inside) {
-          throw new Error("A :" + node.name + "(...) is not allowed inside of a :" + context.inside + "(...)");
+          throw new Error('A :' + node.name + '(...) is not allowed inside of a :' + context.inside + '(...)');
         }
         subContext = {
-          global: (node.name === "global"),
+          global: (node.name === 'global'),
           inside: node.name,
           hasLocals: false,
           explicit: true
@@ -123,12 +123,12 @@ function localizeNode(node, context) {
       }
       break;
 
-    case "id":
-    case "class":
+    case 'id':
+    case 'class':
       if(!context.global) {
         node = {
-          type: "nested-pseudo-class",
-          name: "local",
+          type: 'nested-pseudo-class',
+          name: 'local',
           nodes: [node]
         };
         context.hasLocals = true;
@@ -146,15 +146,15 @@ function localizeNode(node, context) {
 function localizeDeclNode(node, context) {
   var newNode;
   switch(node.type) {
-    case "item":
+    case 'item':
       if(context.localizeNextItem) {
         newNode = Object.create(node);
-        newNode.name = ":local(" + newNode.name + ")";
+        newNode.name = ':local(' + newNode.name + ')';
         context.localizeNextItem = false;
         return newNode;
       }
       break;
-    case "url":
+    case 'url':
       if(context.options && context.options.rewriteUrl) {
         newNode = Object.create(node);
         newNode.url = context.options.rewriteUrl(context.global, node.url);
@@ -193,30 +193,30 @@ module.exports = postcss.plugin('postcss-modules-local-by-default', function (op
     options = {}; // If options is undefined or not an object the plugin fails
   }
   if(options && options.mode) {
-    if(options.mode !== "global" && options.mode !== "local" && options.mode !== "pure") {
-      throw new Error("options.mode must be either 'global', 'local' or 'pure' (default 'local')");
+    if(options.mode !== 'global' && options.mode !== 'local' && options.mode !== 'pure') {
+      throw new Error('options.mode must be either "global", "local" or "pure" (default "local")');
     }
   }
-  var pureMode = options && options.mode === "pure";
-  var globalMode = options && options.mode === "global";
+  var pureMode = options && options.mode === 'pure';
+  var globalMode = options && options.mode === 'global';
   return function(css) {
     css.walkAtRules(function(atrule) {
       if(/keyframes$/.test(atrule.name)) {
         var globalMatch = /^\s*:global\s*\((.+)\)\s*$/.exec(atrule.params);
         var localMatch = /^\s*:local\s*\((.+)\)\s*$/.exec(atrule.params);
         if(globalMatch) {
           if(pureMode) {
-            throw atrule.error("@keyframes :global(...) is not allowed in pure mode");
+            throw atrule.error('@keyframes :global(...) is not allowed in pure mode');
           }
           atrule.params = globalMatch[1];
         } else if(localMatch) {
           atrule.params = localMatch[0];
         } else if(!globalMode) {
-          atrule.params = ":local(" + atrule.params + ")";
+          atrule.params = ':local(' + atrule.params + ')';
         }
       } else if(atrule.nodes) {
         atrule.nodes.forEach(function(decl) {
-          if(decl.type === "decl") {
+          if(decl.type === 'decl') {
             localizeDecl(decl, {
               options: options,
               global: globalMode
@@ -226,7 +226,7 @@ module.exports = postcss.plugin('postcss-modules-local-by-default', function (op
       }
     });
     css.walkRules(function(rule) {
-      if(rule.parent.type === "atrule" && /keyframes$/.test(rule.parent.name)) {
+      if(rule.parent.type === 'atrule' && /keyframes$/.test(rule.parent.name)) {
         // ignore keyframe rules
         return;
       }
@@ -243,8 +243,8 @@ module.exports = postcss.plugin('postcss-modules-local-by-default', function (op
         throw rule.error(e.message);
       }
       if(pureMode && context.hasPureGlobals) {
-        throw rule.error("Selector '" + Tokenizer.stringify(selector) + "' is not pure " +
-          "(pure selectors must contain at least one local class or id)");
+        throw rule.error('Selector "' + Tokenizer.stringify(selector) + '" is not pure ' +
+          '(pure selectors must contain at least one local class or id)');
       }
       rule.nodes.forEach(function(decl) {
         localizeDecl(decl, context);

package.json

@@ -27,7 +27,7 @@
     "tape": "^4.0.0"
   },
   "scripts": {
-    "lint": "eslint index.js",
+    "lint": "eslint index.js test.js",
     "pretest": "npm run lint",
     "test": "tape test.js",
     "autotest": "chokidar index.js test.js -c 'npm test'",

test.js

@@ -177,13 +177,13 @@ var tests = [
   {
     should: 'default to global when mode provided',
     input: '.foo {}',
-    options: { mode: "global" },
+    options: { mode: 'global' },
     expected: '.foo {}'
   },
   {
     should: 'default to local when mode provided',
     input: '.foo {}',
-    options: { mode: "local" },
+    options: { mode: 'local' },
     expected: ':local(.foo) {}'
   },
   {
@@ -199,8 +199,8 @@ var tests = [
       ':local( .a ).b {}',
       ':local(.a) .b {}',
       ':local( .a ) .b {}'
-    ].join("\n"),
-    options: { mode: "global" },
+    ].join('\n'),
+    options: { mode: 'global' },
     expected: [
       '.a :local(.b) {}',
       '.a:local(.b) {}',
@@ -212,7 +212,7 @@ var tests = [
       ':local(.a).b {}',
       ':local(.a) .b {}',
       ':local(.a) .b {}'
-    ].join("\n")
+    ].join('\n')
   },
   {
     should: 'localize keyframes',
@@ -222,7 +222,7 @@ var tests = [
   {
     should: 'localize keyframes in global default mode',
     input: '@keyframes foo {}',
-    options: { mode: "global" },
+    options: { mode: 'global' },
     expected: '@keyframes foo {}'
   },
   {
@@ -243,7 +243,7 @@ var tests = [
   {
     should: 'compile in pure mode',
     input: ':global(.foo).bar, [type="radio"] ~ .label, :not(.foo), #bar {}',
-    options: { mode: "pure" },
+    options: { mode: 'pure' },
     expected: '.foo:local(.bar), [type="radio"] ~ :local(.label), :not(:local(.foo)), :local(#bar) {}'
   },
   {
@@ -260,8 +260,8 @@ var tests = [
   {
     should: 'throw on invalid mode',
     input: '',
-    options: { mode: "???" },
-    error: /'global', 'local' or 'pure'/
+    options: { mode: '???' },
+    error: /"global", "local" or "pure"/
   },
   {
     should: 'throw on inconsistent selector result',
@@ -301,37 +301,37 @@ var tests = [
   {
     should: 'throw on not pure selector (global class)',
     input: ':global(.foo) {}',
-    options: { mode: "pure" },
-    error: /':global\(\.foo\)' is not pure/
+    options: { mode: 'pure' },
+    error: /":global\(\.foo\)" is not pure/
   },
   {
     should: 'throw on not pure selector (with multiple 1)',
     input: '.foo, :global(.bar) {}',
-    options: { mode: "pure" },
-    error: /'.foo, :global\(\.bar\)' is not pure/
+    options: { mode: 'pure' },
+    error: /".foo, :global\(\.bar\)" is not pure/
   },
   {
     should: 'throw on not pure selector (with multiple 2)',
     input: ':global(.bar), .foo {}',
-    options: { mode: "pure" },
-    error: /':global\(\.bar\), .foo' is not pure/
+    options: { mode: 'pure' },
+    error: /":global\(\.bar\), .foo" is not pure/
   },
   {
     should: 'throw on not pure selector (element)',
     input: 'input {}',
-    options: { mode: "pure" },
-    error: /'input' is not pure/
+    options: { mode: 'pure' },
+    error: /"input" is not pure/
   },
   {
     should: 'throw on not pure selector (attribute)',
     input: '[type="radio"] {}',
-    options: { mode: "pure" },
-    error: /'\[type="radio"\]' is not pure/
+    options: { mode: 'pure' },
+    error: /"\[type="radio"\]" is not pure/
   },
   {
     should: 'throw on not pure keyframes',
     input: '@keyframes :global(foo) {}',
-    options: { mode: "pure" },
+    options: { mode: 'pure' },
     error: /@keyframes :global\(\.\.\.\) is not allowed in pure mode/
   },
   {