Skip to content

Commit 990c03d

Browse files
committed
clean up TODOs
1 parent 50c71dd commit 990c03d

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

source-map-support.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ function hasGlobalProcessEventEmitter() {
129129
}
130130

131131
function tryFileURLToPath(v) {
132-
// TODO technically, file URL can omit /s.
133-
// Copy the isFileURL util from resolve-uri?
134132
if(isFileUrl(v)) {
135133
return fileURLToPath(v);
136134
}
@@ -154,8 +152,7 @@ function isSchemeRelativeUrl(input) {
154152
/** @param {string} pathOrFileUrl */
155153
function getCacheKey(pathOrFileUrl) {
156154
if(pathOrFileUrl.startsWith('node:')) return pathOrFileUrl;
157-
// TODO unify with isFileURL checks elsewhere? as helper fn?
158-
if(pathOrFileUrl.startsWith('file:/')) {
155+
if(isFileUrl(pathOrFileUrl)) {
159156
// Must normalize spaces to %20, stuff like that
160157
return new URL(pathOrFileUrl).toString();
161158
} else {

test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ it('eval', async function() {
390390
], [
391391
'Error: test',
392392

393-
// TODO
394393
re`^ at eval \(eval at (<anonymous>|exports\.test|test) \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)`,
395394

396395
re`^ at ${stackFrameAtTest()} \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)$`

0 commit comments

Comments
 (0)