Skip to content

Commit d59344c

Browse files
committed
BUG: clip() should not have out= parameter
1 parent 289203e commit d59344c

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

array_api_compat/common/_aliases.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,6 @@ def clip(
331331
max: Optional[Union[int, float, ndarray]] = None,
332332
*,
333333
xp,
334-
# TODO: np.clip has other ufunc kwargs
335-
out: Optional[ndarray] = None,
336334
) -> ndarray:
337335
def _isscalar(a):
338336
return isinstance(a, (int, float, type(None)))
@@ -368,9 +366,9 @@ def _isscalar(a):
368366
if type(max) is int and max >= wrapped_xp.iinfo(x.dtype).max:
369367
max = None
370368

371-
if out is None:
372-
out = wrapped_xp.asarray(xp.broadcast_to(x, result_shape),
373-
copy=True, device=device(x))
369+
out = wrapped_xp.asarray(xp.broadcast_to(x, result_shape),
370+
copy=True, device=device(x))
371+
374372
if min is not None:
375373
if is_torch_array(x) and x.dtype == xp.float64 and _isscalar(min):
376374
# Avoid loss of precision due to torch defaulting to float32

0 commit comments

Comments
 (0)