Skip to content

Commit c13b947

Browse files
committed
Merge pull request #282 from DaGenix/fixups
Fix some warnings
2 parents 017efb2 + 7a988e5 commit c13b947

File tree

6 files changed

+62
-62
lines changed

6 files changed

+62
-62
lines changed

src/aes.rs

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,23 @@ pub fn ecb_encryptor<X: PaddingProcessor + Send + 'static>(
3030
if util::supports_aesni() {
3131
let aes_enc = aesni::AesNiEncryptor::new(key_size, key);
3232
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
33-
enc as Box<Encryptor>
33+
enc
3434
} else {
3535
match key_size {
3636
KeySize::KeySize128 => {
3737
let aes_enc = aessafe::AesSafe128Encryptor::new(key);
3838
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
39-
enc as Box<Encryptor>
39+
enc
4040
}
4141
KeySize::KeySize192 => {
4242
let aes_enc = aessafe::AesSafe192Encryptor::new(key);
4343
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
44-
enc as Box<Encryptor>
44+
enc
4545
}
4646
KeySize::KeySize256 => {
4747
let aes_enc = aessafe::AesSafe256Encryptor::new(key);
4848
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
49-
enc as Box<Encryptor>
49+
enc
5050
}
5151
}
5252
}
@@ -62,17 +62,17 @@ pub fn ecb_encryptor<X: PaddingProcessor + Send + 'static>(
6262
KeySize::KeySize128 => {
6363
let aes_enc = aessafe::AesSafe128Encryptor::new(key);
6464
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
65-
enc as Box<Encryptor>
65+
enc
6666
}
6767
KeySize::KeySize192 => {
6868
let aes_enc = aessafe::AesSafe192Encryptor::new(key);
6969
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
70-
enc as Box<Encryptor>
70+
enc
7171
}
7272
KeySize::KeySize256 => {
7373
let aes_enc = aessafe::AesSafe256Encryptor::new(key);
7474
let enc = Box::new(EcbEncryptor::new(aes_enc, padding));
75-
enc as Box<Encryptor>
75+
enc
7676
}
7777
}
7878
}
@@ -86,23 +86,23 @@ pub fn ecb_decryptor<X: PaddingProcessor + Send + 'static>(
8686
if util::supports_aesni() {
8787
let aes_dec = aesni::AesNiDecryptor::new(key_size, key);
8888
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
89-
dec as Box<Decryptor>
89+
dec
9090
} else {
9191
match key_size {
9292
KeySize::KeySize128 => {
9393
let aes_dec = aessafe::AesSafe128Decryptor::new(key);
9494
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
95-
dec as Box<Decryptor>
95+
dec
9696
}
9797
KeySize::KeySize192 => {
9898
let aes_dec = aessafe::AesSafe192Decryptor::new(key);
9999
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
100-
dec as Box<Decryptor>
100+
dec
101101
}
102102
KeySize::KeySize256 => {
103103
let aes_dec = aessafe::AesSafe256Decryptor::new(key);
104104
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
105-
dec as Box<Decryptor>
105+
dec
106106
}
107107
}
108108
}
@@ -118,17 +118,17 @@ pub fn ecb_decryptor<X: PaddingProcessor + Send + 'static>(
118118
KeySize::KeySize128 => {
119119
let aes_dec = aessafe::AesSafe128Decryptor::new(key);
120120
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
121-
dec as Box<Decryptor>
121+
dec
122122
}
123123
KeySize::KeySize192 => {
124124
let aes_dec = aessafe::AesSafe192Decryptor::new(key);
125125
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
126-
dec as Box<Decryptor>
126+
dec
127127
}
128128
KeySize::KeySize256 => {
129129
let aes_dec = aessafe::AesSafe256Decryptor::new(key);
130130
let dec = Box::new(EcbDecryptor::new(aes_dec, padding));
131-
dec as Box<Decryptor>
131+
dec
132132
}
133133
}
134134
}
@@ -143,23 +143,23 @@ pub fn cbc_encryptor<X: PaddingProcessor + Send + 'static>(
143143
if util::supports_aesni() {
144144
let aes_enc = aesni::AesNiEncryptor::new(key_size, key);
145145
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
146-
enc as Box<Encryptor>
146+
enc
147147
} else {
148148
match key_size {
149149
KeySize::KeySize128 => {
150150
let aes_enc = aessafe::AesSafe128Encryptor::new(key);
151151
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
152-
enc as Box<Encryptor>
152+
enc
153153
}
154154
KeySize::KeySize192 => {
155155
let aes_enc = aessafe::AesSafe192Encryptor::new(key);
156156
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
157-
enc as Box<Encryptor>
157+
enc
158158
}
159159
KeySize::KeySize256 => {
160160
let aes_enc = aessafe::AesSafe256Encryptor::new(key);
161161
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
162-
enc as Box<Encryptor>
162+
enc
163163
}
164164
}
165165
}
@@ -176,17 +176,17 @@ pub fn cbc_encryptor<X: PaddingProcessor + Send + 'static>(
176176
KeySize::KeySize128 => {
177177
let aes_enc = aessafe::AesSafe128Encryptor::new(key);
178178
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
179-
enc as Box<Encryptor>
179+
enc
180180
}
181181
KeySize::KeySize192 => {
182182
let aes_enc = aessafe::AesSafe192Encryptor::new(key);
183183
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
184-
enc as Box<Encryptor>
184+
enc
185185
}
186186
KeySize::KeySize256 => {
187187
let aes_enc = aessafe::AesSafe256Encryptor::new(key);
188188
let enc = Box::new(CbcEncryptor::new(aes_enc, padding, iv.to_vec()));
189-
enc as Box<Encryptor>
189+
enc
190190
}
191191
}
192192
}
@@ -201,23 +201,23 @@ pub fn cbc_decryptor<X: PaddingProcessor + Send + 'static>(
201201
if util::supports_aesni() {
202202
let aes_dec = aesni::AesNiDecryptor::new(key_size, key);
203203
let dec = Box::new(CbcDecryptor::new(aes_dec, padding, iv.to_vec()));
204-
dec as Box<Decryptor>
204+
dec
205205
} else {
206206
match key_size {
207207
KeySize::KeySize128 => {
208208
let aes_dec = aessafe::AesSafe128Decryptor::new(key);
209209
let dec = Box::new(CbcDecryptor::new(aes_dec, padding, iv.to_vec()));
210-
dec as Box<Decryptor>
210+
dec
211211
}
212212
KeySize::KeySize192 => {
213213
let aes_dec = aessafe::AesSafe192Decryptor::new(key);
214214
let dec = Box::new(CbcDecryptor::new(aes_dec, padding, iv.to_vec()));
215-
dec as Box<Decryptor>
215+
dec
216216
}
217217
KeySize::KeySize256 => {
218218
let aes_dec = aessafe::AesSafe256Decryptor::new(key);
219219
let dec = Box::new(CbcDecryptor::new(aes_dec, padding, iv.to_vec()));
220-
dec as Box<Decryptor>
220+
dec
221221
}
222222
}
223223
}
@@ -258,23 +258,23 @@ pub fn ctr(
258258
if util::supports_aesni() {
259259
let aes_dec = aesni::AesNiEncryptor::new(key_size, key);
260260
let dec = Box::new(CtrMode::new(aes_dec, iv.to_vec()));
261-
dec as Box<SynchronousStreamCipher>
261+
dec
262262
} else {
263263
match key_size {
264264
KeySize::KeySize128 => {
265265
let aes_dec = aessafe::AesSafe128EncryptorX8::new(key);
266266
let dec = Box::new(CtrModeX8::new(aes_dec, iv));
267-
dec as Box<SynchronousStreamCipher>
267+
dec
268268
}
269269
KeySize::KeySize192 => {
270270
let aes_dec = aessafe::AesSafe192EncryptorX8::new(key);
271271
let dec = Box::new(CtrModeX8::new(aes_dec, iv));
272-
dec as Box<SynchronousStreamCipher>
272+
dec
273273
}
274274
KeySize::KeySize256 => {
275275
let aes_dec = aessafe::AesSafe256EncryptorX8::new(key);
276276
let dec = Box::new(CtrModeX8::new(aes_dec, iv));
277-
dec as Box<SynchronousStreamCipher>
277+
dec
278278
}
279279
}
280280
}

src/cryptoutil.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ pub fn write_u32v_le (dst: &mut[u8], input: &[u32]) {
9696
pub fn read_u64v_be(dst: &mut[u64], input: &[u8]) {
9797
assert!(dst.len() * 8 == input.len());
9898
unsafe {
99-
let mut x = dst.get_unchecked_mut(0) as *mut u64;
100-
let mut y = input.get_unchecked(0) as *const u8;
99+
let mut x: *mut u64 = dst.get_unchecked_mut(0);
100+
let mut y: *const u8 = input.get_unchecked(0);
101101
for _ in (0..dst.len()) {
102102
let mut tmp: u64 = mem::uninitialized();
103103
ptr::copy_nonoverlapping(&mut tmp as *mut _ as *mut u8, y, 8);
@@ -112,8 +112,8 @@ pub fn read_u64v_be(dst: &mut[u64], input: &[u8]) {
112112
pub fn read_u64v_le(dst: &mut[u64], input: &[u8]) {
113113
assert!(dst.len() * 8 == input.len());
114114
unsafe {
115-
let mut x = dst.get_unchecked_mut(0) as *mut u64;
116-
let mut y = input.get_unchecked(0) as *const u8;
115+
let mut x: *mut u64 = dst.get_unchecked_mut(0);
116+
let mut y: *const u8 = input.get_unchecked(0);
117117
for _ in (0..dst.len()) {
118118
let mut tmp: u64 = mem::uninitialized();
119119
ptr::copy_nonoverlapping(&mut tmp as *mut _ as *mut u8, y, 8);
@@ -128,8 +128,8 @@ pub fn read_u64v_le(dst: &mut[u64], input: &[u8]) {
128128
pub fn read_u32v_be(dst: &mut[u32], input: &[u8]) {
129129
assert!(dst.len() * 4 == input.len());
130130
unsafe {
131-
let mut x = dst.get_unchecked_mut(0) as *mut u32;
132-
let mut y = input.get_unchecked(0) as *const u8;
131+
let mut x: *mut u32 = dst.get_unchecked_mut(0);
132+
let mut y: *const u8 = input.get_unchecked(0);
133133
for _ in (0..dst.len()) {
134134
let mut tmp: u32 = mem::uninitialized();
135135
ptr::copy_nonoverlapping(&mut tmp as *mut _ as *mut u8, y, 4);
@@ -144,8 +144,8 @@ pub fn read_u32v_be(dst: &mut[u32], input: &[u8]) {
144144
pub fn read_u32v_le(dst: &mut[u32], input: &[u8]) {
145145
assert!(dst.len() * 4 == input.len());
146146
unsafe {
147-
let mut x = dst.get_unchecked_mut(0) as *mut u32;
148-
let mut y = input.get_unchecked(0) as *const u8;
147+
let mut x: *mut u32 = dst.get_unchecked_mut(0);
148+
let mut y: *const u8 = input.get_unchecked(0);
149149
for _ in (0..dst.len()) {
150150
let mut tmp: u32 = mem::uninitialized();
151151
ptr::copy_nonoverlapping(&mut tmp as *mut _ as *mut u8, y, 4);

src/hc128.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ impl Hc128 {
5252
}
5353

5454
for i in 16..1280 {
55-
w[i] = (f2(w[i - 2]).wrapping_add(w[i - 7]).wrapping_add(f1(w[i - 15])).wrapping_add(w[i - 16]).wrapping_add(i as u32)) as u32;
55+
w[i] = f2(w[i - 2]).wrapping_add(w[i - 7]).wrapping_add(f1(w[i - 15])).wrapping_add(w[i - 16]).wrapping_add(i as u32);
5656
}
5757

5858
// Copy contents of w into p and q
@@ -126,7 +126,7 @@ impl SynchronousStreamCipher for Hc128 {
126126
*outb = *inb ^ self.next();
127127
}
128128
} else {
129-
let mut data_index = 0 as usize;
129+
let mut data_index = 0;
130130
let data_index_end = data_index + input.len();
131131

132132
/* Process any unused keystream (self.buffer)

src/poly1305.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ impl Poly1305 {
8383
d2 += c as u64; c = (d2 >> 26) as u32; h2 = d2 as u32 & 0x3ffffff;
8484
d3 += c as u64; c = (d3 >> 26) as u32; h3 = d3 as u32 & 0x3ffffff;
8585
d4 += c as u64; c = (d4 >> 26) as u32; h4 = d4 as u32 & 0x3ffffff;
86-
h0 += c * 5; c = (h0 >> 26) as u32; h0 = h0 & 0x3ffffff;
86+
h0 += c * 5; c = h0 >> 26; h0 = h0 & 0x3ffffff;
8787
h1 += c;
8888

8989
self.h[0] = h0;

src/scrypt.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ pub fn scrypt_check(password: &str, hashed_value: &str) -> Result<bool, &'static
347347
match fstr {
348348
"0" => {
349349
if pvec.len() != 3 { return Err(ERR_STR); }
350-
let log_n = pvec[0] as u8;
350+
let log_n = pvec[0];
351351
let r = pvec[1] as u32;
352352
let p = pvec[2] as u32;
353353
params = ScryptParams::new(log_n, r, p);

0 commit comments

Comments
 (0)