Skip to content

Commit 06c24d6

Browse files
committed
refactor: remove iconHtml prop from buttonClose component
1 parent e6cbd07 commit 06c24d6

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

src/components/button/CButtonClose.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ export default {
44
name: 'CButtonClose',
55
functional: true,
66
props: {
7-
iconHtml: {
8-
type: String,
9-
default: '×'
10-
},
117
buttonClasses: {
128
type: [String, Array, Object],
139
default: 'close'
@@ -22,7 +18,7 @@ export default {
2218
type: 'button',
2319
'aria-label': 'Close'
2420
},
25-
domProps: !slots().default ? { innerHTML: props.iconHtml } : null
21+
domProps: !slots().default ? { innerHTML: '×' } : null
2622
}),
2723
slots().default
2824
)

src/components/button/tests/CButtonClose.spec.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@ const slotWrapper = mount(Component, {
1111
const customWrapper = mount(Component, {
1212
context: {
1313
props: {
14-
iconHtml: 'ok',
1514
buttonClasses: 'custom-class'
1615
}
1716
},
1817
attrs: {
1918
disabled: 'disabled',
2019
style: 'color:red'
20+
},
21+
slots: {
22+
default: 'ok'
2123
}
2224
})
2325

src/components/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ export declare class CButton extends CLink {
3838
}
3939

4040
export declare class CButtonClose extends Vue {
41-
iconHtml: string
4241
buttonClasses: [string, Array<any>, object]
4342
}
4443

0 commit comments

Comments
 (0)