Skip to content

Fix Test Coverage Reporting #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Fix Test Coverage Reporting #1892

merged 15 commits into from
Jan 9, 2025

Conversation

GunalKupta
Copy link
Contributor

@GunalKupta GunalKupta commented Jan 7, 2025

What

Follow-up from #1887 implementation. Fixes bugs in the build pipeline.

  • Revert tox changes
  • Reuse the existing source-package-verification.sh script to run coverage tests instead of tox

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
    • No code changes

References

JIRA: DGS-16859

Test & Review

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@GunalKupta GunalKupta changed the title Run tests in virtualenv Fix Test Coverage Reporting Jan 9, 2025
@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@GunalKupta GunalKupta marked this pull request as ready for review January 9, 2025 18:35
@GunalKupta GunalKupta requested review from a team as code owners January 9, 2025 18:35
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (61.00% Estimated after merge)
  • Duplications No duplication information (0.80% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GunalKupta GunalKupta merged commit aebcb1f into master Jan 9, 2025
2 checks passed
@GunalKupta GunalKupta deleted the kunal/fix-test-task branch January 9, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants