Skip to content

Commit 01fe4dd

Browse files
fix: add Optional on public api for avro (de)serializer where the default is None (#1898)
Co-authored-by: Robert Yokota <rayokota@gmail.com>
1 parent 0d5810a commit 01fe4dd

File tree

1 file changed

+10
-10
lines changed
  • src/confluent_kafka/schema_registry

1 file changed

+10
-10
lines changed

src/confluent_kafka/schema_registry/avro.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,10 @@ def __init__(
221221
self,
222222
schema_registry_client: SchemaRegistryClient,
223223
schema_str: Union[str, Schema, None] = None,
224-
to_dict: Callable[[object, SerializationContext], dict] = None,
225-
conf: dict = None,
226-
rule_conf: dict = None,
227-
rule_registry: RuleRegistry = None
224+
to_dict: Optional[Callable[[object, SerializationContext], dict]] = None,
225+
conf: Optional[dict] = None,
226+
rule_conf: Optional[dict] = None,
227+
rule_registry: Optional[RuleRegistry] = None
228228
):
229229
super().__init__()
230230
if isinstance(schema_str, str):
@@ -306,7 +306,7 @@ def __init__(
306306
rule.configure(self._registry.config() if self._registry else {},
307307
rule_conf if rule_conf else {})
308308

309-
def __call__(self, obj: object, ctx: SerializationContext = None) -> Optional[bytes]:
309+
def __call__(self, obj: object, ctx: Optional[SerializationContext] = None) -> Optional[bytes]:
310310
"""
311311
Serializes an object to Avro binary format, prepending it with Confluent
312312
Schema Registry framing.
@@ -455,11 +455,11 @@ def __init__(
455455
self,
456456
schema_registry_client: SchemaRegistryClient,
457457
schema_str: Union[str, Schema, None] = None,
458-
from_dict: Callable[[dict, SerializationContext], object] = None,
458+
from_dict: Optional[Callable[[dict, SerializationContext], object]] = None,
459459
return_record_name: bool = False,
460-
conf: dict = None,
461-
rule_conf: dict = None,
462-
rule_registry: RuleRegistry = None
460+
conf: Optional[dict] = None,
461+
rule_conf: Optional[dict] = None,
462+
rule_registry: Optional[RuleRegistry] = None
463463
):
464464
super().__init__()
465465
schema = None
@@ -515,7 +515,7 @@ def __init__(
515515
rule.configure(self._registry.config() if self._registry else {},
516516
rule_conf if rule_conf else {})
517517

518-
def __call__(self, data: bytes, ctx: SerializationContext = None) -> Union[dict, object, None]:
518+
def __call__(self, data: bytes, ctx: Optional[SerializationContext] = None) -> Union[dict, object, None]:
519519
"""
520520
Deserialize Avro binary encoded data with Confluent Schema Registry framing to
521521
a dict, or object instance according to from_dict, if specified.

0 commit comments

Comments
 (0)