Skip to content

Commit c301b2b

Browse files
authored
[packaging] Update value for ProductArchitecture (#883)
In swiftlang/swift-installer-scripts#358, the ProductArchitecture value for packaging the Android SDK was changed.
1 parent 28fcc1d commit c301b2b

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

.github/workflows/swift-toolchain.yml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3612,16 +3612,16 @@ jobs:
36123612
matrix:
36133613
include:
36143614
- arch: arm64
3615-
cpu: aarch64
3615+
msarch: arm64
36163616
triple_no_api_level: aarch64-unknown-linux-android
36173617
- arch: armv7
3618-
cpu: armv7
3618+
msarch: arm
36193619
triple_no_api_level: armv7-unknown-linux-androideabi
36203620
- arch: i686
3621-
cpu: i686
3621+
msarch: x86
36223622
triple_no_api_level: i686-unknown-linux-android
36233623
- arch: x86_64
3624-
cpu: x86_64
3624+
msarch: amd64
36253625
triple_no_api_level: x86_64-unknown-linux-android
36263626

36273627
steps:
@@ -3676,6 +3676,12 @@ jobs:
36763676
- name: Package SDK
36773677
if: inputs.build_android
36783678
run: |
3679+
if ("${{ inputs.build_arch }}" -eq "amd64") {
3680+
$InstallerPlatform = "x64"
3681+
} else {
3682+
$InstallerPlatform = "arm64"
3683+
}
3684+
36793685
msbuild -nologo -restore -maxCpuCount `
36803686
-p:BaseOutputPath=${{ github.workspace }}\BinaryCache\installer\ `
36813687
-p:Configuration=Release `
@@ -3686,16 +3692,17 @@ jobs:
36863692
-p:PLATFORM_ROOT=${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Android.platform `
36873693
-p:SDK_ROOT=${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Android.platform/Developer/SDKs/Android.sdk `
36883694
-p:ProductVersion=${{ inputs.swift_version }} `
3689-
-p:ProductArchitecture=${{ matrix.cpu }} `
3695+
-p:ProductArchitecture=${{ matrix.msarch }} `
3696+
-p:InstallerPlatform=${InstallerPlatform} `
36903697
${{ github.workspace }}/SourceCache/swift-installer-scripts/platforms/Windows/sdk/drd/sdk.wixproj
36913698
36923699
- uses: actions/upload-artifact@v4
36933700
if: inputs.build_android
36943701
with:
36953702
name: sdk-android-${{ matrix.arch }}-msi
36963703
path: |
3697-
${{ github.workspace }}/BinaryCache/installer/Release/${{ matrix.cpu }}/sdk.android.${{ matrix.cpu }}.msi
3698-
${{ github.workspace }}/BinaryCache/installer/Release/${{ matrix.cpu }}/sdk.android.${{ matrix.cpu }}.cab
3704+
${{ github.workspace }}/BinaryCache/installer/Release/${{ matrix.msarch }}/sdk.android.${{ matrix.msarch }}.msi
3705+
${{ github.workspace }}/BinaryCache/installer/Release/${{ matrix.msarch }}/sdk.android.${{ matrix.msarch }}.cab
36993706
37003707
installer:
37013708
# TODO: Build this on macOS or make an equivalent Mac-only job

0 commit comments

Comments
 (0)