Skip to content

Commit 9173780

Browse files
committed
Make filters implicit; Update symbols
1 parent 06cc1ab commit 9173780

File tree

2 files changed

+21
-25
lines changed

2 files changed

+21
-25
lines changed

util/gh-pages/index.html

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@
109109
right: 0;
110110
left: auto;
111111
}
112+
113+
#version-filter-count {
114+
display: none;
115+
}
112116
}
113117

114118
.label {
@@ -297,7 +301,7 @@
297301

298302
#version-filter li label {
299303
padding-right: 0;
300-
width: 80%;
304+
width: 40%;
301305
}
302306

303307
.version-filter-input {
@@ -425,7 +429,7 @@ <h1>Clippy Lints</h1>
425429
<div id="version-filter">
426430
<div class="btn-group" filter-dropdown>
427431
<button type="button" class="btn btn-default dropdown-toggle">
428-
Version <span class="caret"></span>
432+
Version <span id="version-filter-count" class="badge">{{versionFilterCount(version_filters)}}</span> <span class="caret"></span>
429433
</button>
430434
<ul id="version-filter-selector" class="dropdown-menu">
431435
<li class="checkbox">
@@ -436,11 +440,8 @@ <h1>Clippy Lints</h1>
436440
</li>
437441
<li role="separator" class="divider"></li>
438442
<li class="checkbox" ng-repeat="(filter, vars) in version_filters">
439-
<label>
440-
<input type="checkbox" ng-model="version_filters[filter].enabled" />
441-
{{filter}}
442-
</label>
443-
<input type="text" class="version-filter-input form-control filter-input" maxlength="6" placeholder="1.62.0" ng-model="version_filters[filter].version_str" ng-model-options="{debounce: 50}"/>
443+
<label ng-attr-for="filter-{filter}">{{filter}}</label>
444+
<input type="text" ng-attr-id="filter-{filter}" class="version-filter-input form-control filter-input" maxlength="6" placeholder="1.62.0" ng-model="version_filters[filter].version_str" ng-model-options="{debounce: 50}"/>
444445
</li>
445446
</ul>
446447
</div>

util/gh-pages/script.js

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,13 @@
137137
$scope.themes = THEMES_DEFAULT;
138138

139139
const DEFAULT_VERSION_FILTERS = {
140-
">=": { enabled: false, version_str: "" },
141-
"<=": { enabled: false, version_str: "" },
142-
"==": { enabled: false, version_str: "" },
140+
"": { enabled: false, version_str: "" },
141+
"": { enabled: false, version_str: "" },
142+
"=": { enabled: false, version_str: "" },
143143
};
144144
// Weird workaround to get a copy of the object
145145
$scope.version_filters = JSON.parse(JSON.stringify(DEFAULT_VERSION_FILTERS));
146-
$scope.version_regex = new RegExp('\\d\.\\d{2}\.\\d');
146+
$scope.version_regex = new RegExp('1\.\\d{2}\.\\d');
147147

148148
$scope.selectTheme = function (theme) {
149149
setTheme(theme, true);
@@ -175,16 +175,8 @@
175175
$scope.version_filters = JSON.parse(JSON.stringify(DEFAULT_VERSION_FILTERS));
176176
}
177177

178-
$scope.versionSymbol = function() {
179-
const version_filters = $scope.version_filters;
180-
let filter = ">=";
181-
for (const key in version_filters) {
182-
if (version_filters[key]) {
183-
filter = key;
184-
}
185-
}
186-
187-
return filter;
178+
$scope.versionFilterCount = function(obj) {
179+
return Object.values(obj).filter(x => x.enabled).length;
188180
}
189181

190182
$scope.byVersion = function(lint) {
@@ -214,10 +206,13 @@
214206
let version_str = filters[filter].version_str;
215207

216208
// Skip the work for version strings with invalid lengths or characters
217-
if (!filters[filter].enabled || !validate_version_str(version_str)) {
209+
if (!validate_version_str(version_str)) {
210+
filters[filter].enabled = false;
218211
continue;
219212
}
220213

214+
filters[filter].enabled = true;
215+
221216
let result = cmp_version(lint_version, version_str, filter);
222217
if (result && filter === "==") {
223218
return true;
@@ -226,10 +221,10 @@
226221
}
227222

228223
let cmp_filter;
229-
if (filter === ">=") {
230-
cmp_filter = "<=";
224+
if (filter === "") {
225+
cmp_filter = "";
231226
} else {
232-
cmp_filter = ">=";
227+
cmp_filter = "";
233228
}
234229

235230
let cmp_version_str = filters[cmp_filter].version_str;

0 commit comments

Comments
 (0)