Skip to content

Commit 78d12b7

Browse files
authored
Rollup merge of rust-lang#142566 - Kobzol:ci-nopt-fix, r=jieyouxu
Fix `-nopt` CI jobs They were using `--config` instead of `--set`, which overrides too much stuff after recent changes to config merging. Should hopefully unblock rust-lang#142447. r? `@jieyouxu`
2 parents f1dd5fb + 743c2a4 commit 78d12b7

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

src/ci/docker/host-x86_64/i686-gnu-nopt/Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
2222
COPY scripts/sccache.sh /scripts/
2323
RUN sh /scripts/sccache.sh
2424

25-
RUN mkdir -p /config
26-
RUN echo "[rust]" > /config/nopt-std-config.toml
27-
RUN echo "optimize = false" >> /config/nopt-std-config.toml
28-
2925
ENV RUST_CONFIGURE_ARGS --build=i686-unknown-linux-gnu --disable-optimize-tests
3026
ARG SCRIPT_ARG
3127
COPY scripts/stage_2_test_set1.sh /scripts/

src/ci/docker/host-x86_64/x86_64-gnu-nopt/Dockerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
2222
COPY scripts/sccache.sh /scripts/
2323
RUN sh /scripts/sccache.sh
2424

25-
RUN mkdir -p /config
26-
RUN echo "[rust]" > /config/nopt-std-config.toml
27-
RUN echo "optimize = false" >> /config/nopt-std-config.toml
28-
2925
ENV RUST_CONFIGURE_ARGS --build=x86_64-unknown-linux-gnu \
3026
--disable-optimize-tests \
3127
--set rust.test-compare-mode
32-
ENV SCRIPT python3 ../x.py test --stage 1 --config /config/nopt-std-config.toml library/std \
28+
ENV SCRIPT python3 ../x.py test --stage 1 --set rust.optimize=false library/std \
3329
&& python3 ../x.py --stage 2 test

src/ci/github-actions/jobs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ auto:
300300
env:
301301
IMAGE: i686-gnu-nopt
302302
DOCKER_SCRIPT: >-
303-
python3 ../x.py test --stage 1 --config /config/nopt-std-config.toml library/std &&
303+
python3 ../x.py test --stage 1 --set rust.optimize=false library/std &&
304304
/scripts/stage_2_test_set2.sh
305305
<<: *job-linux-4c
306306

0 commit comments

Comments
 (0)