Skip to content

Commit 44972b2

Browse files
committed
Mark incremental-ignore-spans as TRACKED.
Using that options basically changes all stable hashes we may compute. Adding/removing as UNTRACKED it makes everything ICE (unstable fingerprint everywhere). As TRACKED, it can still do its job without ICEing.
1 parent 6d42636 commit 44972b2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

compiler/rustc_interface/src/tests.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,6 @@ fn test_unstable_options_tracking_hash() {
652652
untracked!(future_incompat_test, true);
653653
untracked!(hir_stats, true);
654654
untracked!(identify_regions, true);
655-
untracked!(incremental_ignore_spans, true);
656655
untracked!(incremental_info, true);
657656
untracked!(incremental_verify_ich, true);
658657
untracked!(input_stats, true);
@@ -737,6 +736,7 @@ fn test_unstable_options_tracking_hash() {
737736
tracked!(fuel, Some(("abc".to_string(), 99)));
738737
tracked!(function_sections, Some(false));
739738
tracked!(human_readable_cgu_names, true);
739+
tracked!(incremental_ignore_spans, true);
740740
tracked!(inline_in_all_cgus, Some(true));
741741
tracked!(inline_mir, Some(true));
742742
tracked!(inline_mir_hint_threshold, Some(123));

compiler/rustc_session/src/options.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1333,7 +1333,7 @@ options! {
13331333
"generate human-readable, predictable names for codegen units (default: no)"),
13341334
identify_regions: bool = (false, parse_bool, [UNTRACKED],
13351335
"display unnamed regions as `'<id>`, using a non-ident unique id (default: no)"),
1336-
incremental_ignore_spans: bool = (false, parse_bool, [UNTRACKED],
1336+
incremental_ignore_spans: bool = (false, parse_bool, [TRACKED],
13371337
"ignore spans during ICH computation -- used for testing (default: no)"),
13381338
incremental_info: bool = (false, parse_bool, [UNTRACKED],
13391339
"print high-level information about incremental reuse (or the lack thereof) \

0 commit comments

Comments
 (0)