Skip to content

Commit 85027f7

Browse files
committed
refactor(commands/bump): rename parameter into bump_setting to distinguish bump_setting and argument
1 parent 9f93074 commit 85027f7

File tree

1 file changed

+19
-21
lines changed

1 file changed

+19
-21
lines changed

commitizen/commands/bump.py

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,11 @@ class Bump:
2020
def __init__(self, config: BaseConfig, arguments: dict):
2121
self.config: BaseConfig = config
2222
self.arguments: dict = arguments
23-
self.parameters: dict = {
23+
self.bump_settings: dict = {
2424
**config.settings,
2525
**{
2626
key: arguments[key]
27-
for key in [
28-
"dry_run",
29-
"tag_format",
30-
"prerelease",
31-
"increment",
32-
"bump_message",
33-
]
27+
for key in ["tag_format", "prerelease", "increment", "bump_message"]
3428
if arguments[key] is not None
3529
},
3630
}
@@ -65,10 +59,10 @@ def find_increment(self, commits: List[git.GitCommit]) -> Optional[str]:
6559
)
6660
return increment
6761

68-
def __call__(self):
62+
def __call__(self): # noqa: C901
6963
"""Steps executed to bump."""
7064
try:
71-
current_version_instance: Version = Version(self.parameters["version"])
65+
current_version_instance: Version = Version(self.bump_settings["version"])
7266
except TypeError:
7367
out.error(
7468
"[NO_VERSION_SPECIFIED]\n"
@@ -79,19 +73,21 @@ def __call__(self):
7973

8074
# Initialize values from sources (conf)
8175
current_version: str = self.config.settings["version"]
82-
tag_format: str = self.parameters["tag_format"]
83-
bump_commit_message: str = self.parameters["bump_message"]
84-
current_tag_version: str = bump.create_tag(
85-
current_version, tag_format=tag_format
86-
)
87-
version_files: list = self.parameters["version_files"]
88-
dry_run: bool = self.parameters["dry_run"]
8976

77+
tag_format: str = self.bump_settings["tag_format"]
78+
bump_commit_message: str = self.bump_settings["bump_message"]
79+
version_files: list = self.bump_settings["version_files"]
80+
81+
dry_run: bool = self.arguments["dry_run"]
9082
is_yes: bool = self.arguments["yes"]
91-
prerelease: str = self.arguments["prerelease"]
9283
increment: Optional[str] = self.arguments["increment"]
84+
prerelease: str = self.arguments["prerelease"]
9385
is_files_only: Optional[bool] = self.arguments["files_only"]
9486

87+
current_tag_version: str = bump.create_tag(
88+
current_version, tag_format=tag_format
89+
)
90+
9591
is_initial = self.is_initial_tag(current_tag_version, is_yes)
9692
if is_initial:
9793
commits = git.get_commits()
@@ -121,9 +117,11 @@ def __call__(self):
121117
)
122118

123119
# Report found information
124-
out.write(message)
125-
out.write(f"tag to create: {new_tag_version}")
126-
out.write(f"increment detected: {increment}")
120+
out.write(
121+
f"message\n"
122+
f"tag to create: {new_tag_version}\n"
123+
f"increment detected: {increment}\n"
124+
)
127125

128126
# Do not perform operations over files or git.
129127
if dry_run:

0 commit comments

Comments
 (0)