refactor(schema): command logic removed from commitizen base

Author: woile

commitizen/commands/schema.py

@@ -1,4 +1,4 @@
-from commitizen import factory
+from commitizen import factory, out
 
 
 class Schema:
@@ -9,4 +9,4 @@ def __init__(self, config: dict, *args):
         self.cz = factory.commiter_factory(self.config)
 
     def __call__(self):
-        self.cz.show_schema()
+        out.write(self.cz.schema())

commitizen/cz/base.py

@@ -1,4 +1,3 @@
-from commitizen import out
 from abc import ABCMeta, abstractmethod
 
 
@@ -7,14 +6,8 @@ def __init__(self, config: dict):
         self.config = config
 
     @abstractmethod
-    def questions(self):
-        """Questions regarding the commit message.
-
-        Must have 'whaaaaat' format.
-        More info: https://github.com/finklabs/whaaaaat/
-
-        :rtype: list
-        """
+    def questions(self) -> list:
+        """Questions regarding the commit message."""
 
     @abstractmethod
     def message(self, answers: dict) -> dict:
@@ -31,6 +24,3 @@ def schema(self) -> str:
     def info(self) -> str:
         """Information about the standardized commit message."""
         raise NotImplementedError("Not Implemented yet")
-
-    def show_schema(self, *args, **kwargs):
-        out.write(self.schema())

tests/test_commands.py

@@ -36,13 +36,9 @@ def test_info():
 
 
 def test_schema():
-    with mock.patch("commitizen.factory.commiter_factory") as mocked_factory:
-        mock_cz = mock.Mock()
-        mocked_factory.return_value = mock_cz
+    with mock.patch("commitizen.out.write") as write_mock:
         commands.Schema(config)()
-
-        mocked_factory.assert_called_once()
-        mock_cz.show_schema.assert_called_once()
+        write_mock.assert_called_once()
 
 
 def test_list_cz():

tests/test_cz_base.py

@@ -44,9 +44,3 @@ def test_info():
     cz = DummyCz(config)
     with pytest.raises(NotImplementedError):
         cz.info()
-
-
-def test_show_schema():
-    cz = DummyCz(config)
-    with pytest.raises(NotImplementedError):
-        cz.show_schema()