fix: removing folder in windows throwing a PermissionError

* #issue67
created handler for readonly files/dirs to be passed to shutil.rmtree(). will change permissions and retry operation if readonly dir/file found.

* added reference for where handler code came from

* prettied report of c.err

* created exception to raise if unable to change permission in handler

* tidy error report

* correcting style mistakes

Closes #67

Author: gabe-camp

commitizen/commands/bump.py

@@ -122,7 +122,7 @@ def __call__(self):
         bump.update_version_in_files(current_version, new_version.public, files)
         c = git.commit(message, args="-a")
         if c.err:
-            out.error(c.err)
+            out.error("git.commit errror: \"{}\"".format(c.err.strip()))
             raise SystemExit(COMMIT_FAILED)
         c = git.tag(new_tag_version)
         if c.err:

tests/test_bump_command.py

@@ -1,5 +1,7 @@
 import os
 import shutil
+import stat
+import errno
 import sys
 import uuid
 from pathlib import Path
@@ -10,6 +12,20 @@
 from commitizen import cli, cmd, git
 
 
+def ReadOnlyException(Exception):
+    pass
+
+
+# https://stackoverflow.com/questions/1213706/what-user-do-python-scripts-run-as-in-windows
+def handleRemoveReadOnly(func, path, exc):
+    excvalue = exc[1]
+    if func in (os.rmdir, os.remove, shutil.rmtree) and excvalue.errno == errno.EACCESS:
+        os.chmod(path, stat.S_IRWXU | stat.S_IRWXG | stat.IRWXO)  # 744
+        func(path)
+    else:
+        raise ReadOnlyException
+
+
 @pytest.fixture
 def create_project():
     current_directory = os.getcwd()
@@ -20,7 +36,7 @@ def create_project():
     os.chdir(full_tmp_path)
     yield
     os.chdir(current_directory)
-    shutil.rmtree(full_tmp_path)
+    shutil.rmtree(full_tmp_path, handleRemoveReadOnly)
 
 
 def create_file_and_commit(message: str, filename: Optional[str] = None):