From ec8eb0f8b6baaa0d79fbe2e9e4569f5463c566dc Mon Sep 17 00:00:00 2001
From: 1arp
Date: Thu, 24 Sep 2020 22:04:57 +0530
Subject: [PATCH 1/3] change eligibilty criteriafor excellence certificate
---
.../excellence-certificate-modal/component.js | 2 +-
.../excellence-certificate-modal/template.hbs | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
index 50b1794b8..84022af10 100644
--- a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
+++ b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
@@ -15,7 +15,7 @@ export default class ExcellenceCertificateModal extends Component {
@computed('stats')
get isQualifiedForExcellenceCertififcate() {
- return this.courseCompleted && (this.stats.performance.percentile > this.run.get('excellenceThreshold'))
+ return this.courseCompleted && (this.stats.performance.score > this.run.get('excellenceThreshold'))
}
@dropTask excellenceCertificateTask = function* () {
diff --git a/app/pods/components/certificate-comp/excellence-certificate-modal/template.hbs b/app/pods/components/certificate-comp/excellence-certificate-modal/template.hbs
index da5526a66..6863db5a3 100644
--- a/app/pods/components/certificate-comp/excellence-certificate-modal/template.hbs
+++ b/app/pods/components/certificate-comp/excellence-certificate-modal/template.hbs
@@ -22,8 +22,8 @@
- Complete {{run.completionThreshold}}% of the course and be in the top {{run.excellenceThreshold}}
- percentile to generate excellence certificate.
+ Complete {{run.completionThreshold}}% of the course and score {{run.excellenceThreshold}}%
+ of the total score to generate excellence certificate.
{{#if canDownload}}
From 0060593c8e863ced2d8f79a9b991d6713a80e922 Mon Sep 17 00:00:00 2001
From: Abhishek Gupta
Date: Mon, 28 Sep 2020 18:56:51 +0530
Subject: [PATCH 2/3] Update component.js
---
.../excellence-certificate-modal/component.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
index 84022af10..32131892e 100644
--- a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
+++ b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
@@ -15,7 +15,7 @@ export default class ExcellenceCertificateModal extends Component {
@computed('stats')
get isQualifiedForExcellenceCertififcate() {
- return this.courseCompleted && (this.stats.performance.score > this.run.get('excellenceThreshold'))
+ return this.courseCompleted && (this.stats.performance.scoreCompletionPercentage > this.run.get('excellenceThreshold'))
}
@dropTask excellenceCertificateTask = function* () {
@@ -35,4 +35,4 @@ export default class ExcellenceCertificateModal extends Component {
window.open(this.excellenceCertificate.url, '_blank')
}
-};
\ No newline at end of file
+};
From 149b61cb0e37c555ef395c1d34ef3e8f9892a00a Mon Sep 17 00:00:00 2001
From: Abhishek Gupta
Date: Mon, 28 Sep 2020 18:57:18 +0530
Subject: [PATCH 3/3] Update component.js
---
.../certificate-comp/excellence-certificate-modal/component.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
index 32131892e..fc0b9bbd8 100644
--- a/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
+++ b/app/pods/components/certificate-comp/excellence-certificate-modal/component.js
@@ -15,7 +15,7 @@ export default class ExcellenceCertificateModal extends Component {
@computed('stats')
get isQualifiedForExcellenceCertififcate() {
- return this.courseCompleted && (this.stats.performance.scoreCompletionPercentage > this.run.get('excellenceThreshold'))
+ return this.courseCompleted && (this.stats.performance.scoreCompletionPercentage >= this.run.get('excellenceThreshold'))
}
@dropTask excellenceCertificateTask = function* () {