From 2e9c6bb7f934a6074e1ac2210e073a4aa26aafc5 Mon Sep 17 00:00:00 2001 From: Alby Date: Mon, 9 May 2022 07:38:58 +0100 Subject: [PATCH 1/3] more stytle fixes --- src/Http/Controllers/ExportTasksController.php | 1 + src/Http/Controllers/ImportTasksController.php | 1 + src/Http/Controllers/TasksController.php | 2 +- src/Traits/FrontendSortable.php | 6 +++--- src/Traits/HasFrequencies.php | 4 ++-- tests/Feature/ViewDashboardTest.php | 4 ++-- 6 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Http/Controllers/ExportTasksController.php b/src/Http/Controllers/ExportTasksController.php index 91b760eb..4600c537 100644 --- a/src/Http/Controllers/ExportTasksController.php +++ b/src/Http/Controllers/ExportTasksController.php @@ -14,6 +14,7 @@ class ExportTasksController extends Controller /** * ExportTasksController constructor. + * * @param TaskInterface $tasks */ public function __construct(TaskInterface $tasks) diff --git a/src/Http/Controllers/ImportTasksController.php b/src/Http/Controllers/ImportTasksController.php index 0709f9a7..7ba764f7 100644 --- a/src/Http/Controllers/ImportTasksController.php +++ b/src/Http/Controllers/ImportTasksController.php @@ -15,6 +15,7 @@ class ImportTasksController extends Controller /** * ImportTasksController constructor. + * * @param TaskInterface $tasks */ public function __construct(TaskInterface $tasks) diff --git a/src/Http/Controllers/TasksController.php b/src/Http/Controllers/TasksController.php index 93de52e3..e17b9b7c 100644 --- a/src/Http/Controllers/TasksController.php +++ b/src/Http/Controllers/TasksController.php @@ -74,7 +74,7 @@ public function create(): View /** * Store a newly created task in storage. * - * @param TaskRequest $request + * @param TaskRequest $request * @return RedirectResponse */ public function store(TaskRequest $request): RedirectResponse diff --git a/src/Traits/FrontendSortable.php b/src/Traits/FrontendSortable.php index 4540047d..5c8fea83 100644 --- a/src/Traits/FrontendSortable.php +++ b/src/Traits/FrontendSortable.php @@ -7,9 +7,9 @@ trait FrontendSortable { /** - * @param Builder $builder - * @param array $sortableColumns - * @param array $defaultSort + * @param Builder $builder + * @param array $sortableColumns + * @param array $defaultSort $defaultSort * * @return Builder */ diff --git a/src/Traits/HasFrequencies.php b/src/Traits/HasFrequencies.php index f2318ba4..a4f5b631 100644 --- a/src/Traits/HasFrequencies.php +++ b/src/Traits/HasFrequencies.php @@ -122,7 +122,7 @@ public function getCronExpression(): string /** * Determine if the filters pass for the event. * - * @param Application $app + * @param Application $app * @return bool */ public function filtersPass(Application $app): bool @@ -145,7 +145,7 @@ public function filtersPass(Application $app): bool /** * Register a callback to further filter the schedule. * - * @param Closure $callback + * @param Closure $callback * @return $this */ public function when(Closure $callback): static diff --git a/tests/Feature/ViewDashboardTest.php b/tests/Feature/ViewDashboardTest.php index d9dd8b13..1edb8ba5 100644 --- a/tests/Feature/ViewDashboardTest.php +++ b/tests/Feature/ViewDashboardTest.php @@ -80,8 +80,8 @@ public function view_dashboard_multiple_tasks_with_multiple_results() } /** - * @param int $task_count - * @param int $result_count + * @param int $task_count + * @param int $result_count * @return mixed */ private function _get_task_with_results($task_count = 1, $result_count = 1) From ad5133d4fb18b74eec826f8c80ebd1c8698b738e Mon Sep 17 00:00:00 2001 From: Alby Date: Mon, 9 May 2022 07:46:39 +0100 Subject: [PATCH 2/3] fix style fix type --- src/Traits/FrontendSortable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Traits/FrontendSortable.php b/src/Traits/FrontendSortable.php index 5c8fea83..0deabd0e 100644 --- a/src/Traits/FrontendSortable.php +++ b/src/Traits/FrontendSortable.php @@ -9,7 +9,7 @@ trait FrontendSortable /** * @param Builder $builder * @param array $sortableColumns - * @param array $defaultSort $defaultSort + * @param array $defaultSort * * @return Builder */ From d557d6d5fed73b3557b9d6db701e751bf96a2acd Mon Sep 17 00:00:00 2001 From: Alby Date: Mon, 9 May 2022 07:48:04 +0100 Subject: [PATCH 3/3] another style fix --- src/Traits/FrontendSortable.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Traits/FrontendSortable.php b/src/Traits/FrontendSortable.php index 0deabd0e..01339318 100644 --- a/src/Traits/FrontendSortable.php +++ b/src/Traits/FrontendSortable.php @@ -10,7 +10,6 @@ trait FrontendSortable * @param Builder $builder * @param array $sortableColumns * @param array $defaultSort - * * @return Builder */ public function scopeSortableBy(Builder $builder, array $sortableColumns, array $defaultSort = ['name' => 'asc']): Builder